This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Still relevant, moving back to available

Background: I'm trying to replace TintedImageButton with AppCompatImageButton to be able to use vector asset for ic_expand_more_black_24dp and ic_expand_less_black_24dp.

I've found out that replacing TintedImageButton with AppCompatImageButton is tricky, because we have default chrometint specified in MainThemeBase and AlertDialogTheme: https://cs.chromium.org/chromium/src/chrome/android/java/res/values-v17/styles.xml?l=34&rcl=2d7d690ebaf369da71e9fb10167e8769385181a7.

For AppCompatImageButtons to be tinted we would have to change this to "tint", thus all images would be tinted (the same way they were tinted before https://crrev.com/2911253002).

I'm leaning towards removing default tint from styles.xml. It's not good idea to specify it there to start with (it's pretty similar to specifying default color for all Buttons or src for all ImageViews). However, simply removing it may change appearance for some buttons that were relying on this default tinting.

Another option here is to add explicit tint attribute to every TintedImageButton. However, this would somewhat bloat our XML files (and can still break some buttons in activities that don't use MainThemeBase or AlertDialogTheme).

Ted, what's your take on this?

From what I can see, the two possible options are:

1.) Replace chrometint with tint in styles.xml
  * Would require adding tint="@null" or something to all ImageViews that don't want to be tinted

2.) Remove chrometint from styles.xml and mandating each button has tint="..." set explicitly.

Seems like we'd have some APK bloat from either, but conceptually we could chose the one that incurs the least.  With that said, I do think #2 is cleaner and would likely try that approach first.

I would go with the approach of adding chrometint to all TintedImageButtons in XML right now.  If someone was using a TintedImageButton but not specifying a tint, they were likely doing it in XML or relying on the default.  I think tracking down the ones that aren't used as part of the Main style would also be a smaller task than the reverse.  Once all of the TintedImageButtons were tagged with chrometint, we could simply convert them to the appcompat versions (in xml, that would mean just going back to ImageView and relying on AppCompat's magic view replacement for us) and add tint.

It turns out, relying on AppCompat magic won't work here, as some views aren't inflated by magical AppCompat inflater. Specifically, I've found out that views in InfoBar are inflated from context created here: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java?l=596&rcl=1e22f1dda7b3f075ea91b0c95721924cf8d71ade. This context is not connected to AppCompat, so this part of view hierarchy is using regular ImageView, ImageButton, TextView, etc.

Is there any way to circumvent this and inflate InfoBar views using real context? Or should I explicitly specify AppCompatImageButton in XML?

Tab is a wonky beast.  The themed context is useful for when Tab's are created (via CustomTabs) before an activity is present.  In theory, the translate infobar could attempt to show itself even though the tab isn't attached if a page is loaded in the background not in the language you read.

In cases like that, I think it's ok to hardcode the app compat version in the XML.

OK, thanks for the explanation! I'll hardcode it in views that seem to be used in InfoBar.

Back to wonky beasts: can it be that Tab is being shown without being attached to any activity? It can be created and loaded in background, but it should be displayed in an Activity, shouldn't it?
If the answer is "yes", then we could resolve this Context issue by making sure InfoBar.createView isn't called until Tab is attached to an Activity.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c2064240cae074695aac984fcf459db7c5cd78

commit 40c2064240cae074695aac984fcf459db7c5cd78
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Fri Jun 08 13:16:58 2018

[Android] Remove ApiCompatibilityUtils.getColorStateList

This CL replaces ApiCompatibilityUtils.getColorStateList with
AppCompatResources.getColorStateList from Android support library.

Bug:  727723 
Change-Id: I26f4fa3149a9b87bfd150c0d3eb93b16568bfd0d
Reviewed-on: https://chromium-review.googlesource.com/1087052
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565618}
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddEditFolderActivity.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderRow.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ShareContextMenuItem.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ToolbarView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListItemViewHolder.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestHeader.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherDrawable.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedDrawable.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarPhone.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/newtab/NewTabButton.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorTextField.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/HintedDropDownAdapterWithPlusIcon.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/40c2064240cae074695aac984fcf459db7c5cd78/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ImageViewTinterTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/833a777bd10908d49e27a531e985d57541ba7e2d

commit 833a777bd10908d49e27a531e985d57541ba7e2d
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Mon Jun 11 12:27:00 2018

[Android] Remove 'chrometint' from themes in styles.xml

This CL removes theme-wide 'chrometint' attribute, adding explicit
attribute to XMLs tags that instantiate TintedImageView and
TintedImageButton. This is necessary for the upcoming replacement of
TintedImageView and TintedImageButton with AppCompatImageView and
AppCompatImageButton.

Bug:  727723 
Change-Id: Ia935e9e863b09a3384e0c3c0a07cb393ffc5bb34
Reviewed-on: https://chromium-review.googlesource.com/1092866
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565974}
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/accept_languages_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/bookmark_folder_select_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/chip.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/content_suggestions_card_modern.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/contextual_suggestions_card_modern.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/contextual_suggestions_toolbar.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/download_item_view.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/download_location_dialog.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/download_manager_generic_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/find_in_page.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/icon_row_menu_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/menu_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/modern_list_item_view.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/new_tab_page_snippets_expandable_header.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/offline_download_header.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/title_button_menu_item.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/toolbar_phone_common.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/layout/url_action_container.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/833a777bd10908d49e27a531e985d57541ba7e2d/chrome/android/java/src/org/chromium/chrome/browser/widget/ImageViewTinter.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f663354d4dfb3c8ae4782174dcb9591b6ce56bc6

commit f663354d4dfb3c8ae4782174dcb9591b6ce56bc6
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Fri Sep 28 17:23:04 2018

[Android] Use textAppearance in update_menu_item.xml

This CL adds TextAppearance.UpdateMenuItem and replaces hardcoded
textColor and textSize values in update_menu_item.xml.

Bug:  727723 
Change-Id: I1b085d973502143e9a4a44dcbd1013d20386f01c
Reviewed-on: https://chromium-review.googlesource.com/1251539
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595132}
[modify] https://crrev.com/f663354d4dfb3c8ae4782174dcb9591b6ce56bc6/chrome/android/java/res/layout/update_menu_item.xml
[modify] https://crrev.com/f663354d4dfb3c8ae4782174dcb9591b6ce56bc6/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/f663354d4dfb3c8ae4782174dcb9591b6ce56bc6/chrome/android/java/res/values/colors.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af3f31af03ff6f9ab5d71c3c73a294094f1b5538

commit af3f31af03ff6f9ab5d71c3c73a294094f1b5538
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Mon Oct 01 19:29:29 2018

[Android] Replace TintedImageView and TintedImageButton

This CL replaces Chrome-specific tinting view classes with their
AppCompat equivalents: TintedImageView -> AppCompatImageView and
TintedImageButton -> AppCompatImageButton.
1. Entries in XML layouts have fully qualified names because some
   layouts are inflated outside AppCompatActivity, so AppCompat magic
   doesn't work for them.
2. AppCompatImageView doesn't have setTint, so
   ImageViewCompat.setImageTintList is used instead.
3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
   so these are replaced, too.

Bug:  727723 
Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1
Reviewed-on: https://chromium-review.googlesource.com/1245786
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595500}
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/accept_languages_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/accessibility_tab_switcher.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/chip.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/clear_storage.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/content_suggestions_card_modern_reversed.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/contextual_suggestions_card_modern.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/contextual_suggestions_card_modern_alternate.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/contextual_suggestions_toolbar.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/empty_background_view_tablet.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/experimental_toolbar_button.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/find_in_page.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/history_item_view.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/icon_row_menu_footer.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/icon_row_menu_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/infobar_translate_compact_content.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/list_menu_button.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/list_selection_handle_view.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/menu_button.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/modern_list_item_view.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/search_toolbar.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/textbubble_text_with_image.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/title_button_menu_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/toolbar_phone.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/translate_menu_item_checked.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/update_menu_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/layout/url_action_container.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res/values/attrs.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/download_item_view.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/download_location_dialog.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/download_manager_generic_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/download_manager_in_progress_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/res_download/layout/offline_download_header.xml
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuItemIcon.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/GenericViewHolder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressVideoViewHolder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressViewHolder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/home/view/SelectionView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadDirectoryAdapter.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomePageButton.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[delete] https://crrev.com/fedf565505e9acc4e0398db45eff7755f8ce2492/chrome/android/java/src/org/chromium/chrome/browser/widget/ImageViewTinter.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/ListMenuButton.java
[delete] https://crrev.com/fedf565505e9acc4e0398db45eff7755f8ce2492/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java
[delete] https://crrev.com/fedf565505e9acc4e0398db45eff7755f8ce2492/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarPhone.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/incognitotoggle/IncognitoToggleButton.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/java_sources.gni
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java
[modify] https://crrev.com/af3f31af03ff6f9ab5d71c3c73a294094f1b5538/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java
[delete] https://crrev.com/fedf565505e9acc4e0398db45eff7755f8ce2492/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ImageViewTinterTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2569149bf6a0d428ddc36b52058195a15a3eb4a0

commit 2569149bf6a0d428ddc36b52058195a15a3eb4a0
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Mon Oct 01 23:08:05 2018

Revert "[Android] Replace TintedImageView and TintedImageButton"

This reverts commit af3f31af03ff6f9ab5d71c3c73a294094f1b5538.

Reason for revert: Breaks Android buildbot runs with errors like:
  ```../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/IncognitoToggleTabLayout.java:18: error: cannot find symbol
  import org.chromium.chrome.browser.widget.TintedImageView;```
 
Full run here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933828868736954944/+/steps/compile__with_patch_/0/stdout


Original change's description:
> [Android] Replace TintedImageView and TintedImageButton
> 
> This CL replaces Chrome-specific tinting view classes with their
> AppCompat equivalents: TintedImageView -> AppCompatImageView and
> TintedImageButton -> AppCompatImageButton.
> 1. Entries in XML layouts have fully qualified names because some
>    layouts are inflated outside AppCompatActivity, so AppCompat magic
>    doesn't work for them.
> 2. AppCompatImageView doesn't have setTint, so
>    ImageViewCompat.setImageTintList is used instead.
> 3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
>    so these are replaced, too.
> 
> Bug:  727723 
> Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1
> Reviewed-on: https://chromium-review.googlesource.com/1245786
> Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595500}

TBR=tedchoc@chromium.org,twellington@chromium.org,bsazonov@chromium.org,huayinz@chromium.org

Change-Id: I83efa81fce074f24f330281460b2685f1765f0e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  727723 
Reviewed-on: https://chromium-review.googlesource.com/1255456
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595625}
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/accept_languages_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/accessibility_tab_switcher.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/chip.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/clear_storage.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/content_suggestions_card_modern_reversed.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/contextual_suggestions_card_modern.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/contextual_suggestions_card_modern_alternate.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/contextual_suggestions_toolbar.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/empty_background_view_tablet.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/experimental_toolbar_button.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/find_in_page.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/history_item_view.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/icon_row_menu_footer.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/icon_row_menu_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/infobar_translate_compact_content.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/list_menu_button.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/list_selection_handle_view.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/menu_button.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/modern_list_item_view.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/search_toolbar.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/textbubble_text_with_image.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/title_button_menu_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/toolbar_phone.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/translate_menu_item_checked.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/update_menu_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/layout/url_action_container.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res/values/attrs.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/download_item_view.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/download_location_dialog.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/download_manager_generic_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/download_manager_in_progress_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/res_download/layout/offline_download_header.xml
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuItemIcon.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/GenericViewHolder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressVideoViewHolder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressViewHolder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/home/view/SelectionView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadDirectoryAdapter.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomePageButton.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[add] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/ImageViewTinter.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/ListMenuButton.java
[add] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java
[add] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarPhone.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/incognitotoggle/IncognitoToggleButton.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/java_sources.gni
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java
[modify] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java
[add] https://crrev.com/2569149bf6a0d428ddc36b52058195a15a3eb4a0/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ImageViewTinterTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d67649e98707fbf2622e964bf1bf8f8f548a46

commit d9d67649e98707fbf2622e964bf1bf8f8f548a46
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Tue Oct 02 13:23:15 2018

[Android] Replace TintedImageView and TintedImageButton

Reland of https://crrev.com/c/1245786 that was reverted by
https://crrev.com/c/1255456 due to a build failure.

This CL replaces Chrome-specific tinting view classes with their
AppCompat equivalents: TintedImageView -> AppCompatImageView and
TintedImageButton -> AppCompatImageButton.
1. Entries in XML layouts have fully qualified names because some
   layouts are inflated outside AppCompatActivity, so AppCompat magic
   doesn't work for them.
2. AppCompatImageView doesn't have setTint, so
   ImageViewCompat.setImageTintList is used instead.
3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
   so these are replaced, too.

TBR=tedchoc@chromium.org

Bug:  727723 
Change-Id: Iedc6337e2f58c60de2d19cd3ac1787ec7ae7b16e
Reviewed-on: https://chromium-review.googlesource.com/1256783
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595816}
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/accept_languages_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/accessibility_tab_switcher.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/chip.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/clear_storage.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/content_suggestions_card_modern_reversed.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/contextual_suggestions_card_modern.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/contextual_suggestions_card_modern_alternate.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/contextual_suggestions_toolbar.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/empty_background_view_tablet.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/experimental_toolbar_button.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/find_in_page.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/history_item_view.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/icon_row_menu_footer.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/icon_row_menu_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/infobar_translate_compact_content.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/list_menu_button.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/list_selection_handle_view.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/menu_button.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/modern_list_item_view.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/search_toolbar.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/textbubble_text_with_image.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/title_button_menu_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/toolbar_phone.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/translate_menu_item_checked.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/update_menu_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/layout/url_action_container.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res/values/attrs.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/download_item_view.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/download_location_dialog.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/download_manager_generic_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/download_manager_in_progress_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/res_download/layout/offline_download_header.xml
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuItemIcon.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/GenericViewHolder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressVideoViewHolder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressViewHolder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/home/view/SelectionView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadDirectoryAdapter.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomePageButton.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/IncognitoToggleTabLayout.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[delete] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/chrome/android/java/src/org/chromium/chrome/browser/widget/ImageViewTinter.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/ListMenuButton.java
[delete] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java
[delete] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarPhone.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/incognitotoggle/IncognitoToggleButton.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java_sources.gni
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java
[modify] https://crrev.com/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java
[delete] https://crrev.com/fadc1d0a4cf3e09fe3806c03cc6ca38f3c02c418/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ImageViewTinterTest.java

The last CL has caused several visual issues: 856263 891593 891595 891609 891645 892061
892388 893040 893985 899059 (maybe more). All these issues seem to be resolved by now.

I've filed https://crbug.com/917364 to follow-up on TintedDrawable. Closing this out.