DCHECK in overscroll_window_animation.cc |
|||||
Issue descriptionon trunk, when I gesture nav back and forth quickly using touch I get this DCHECK: [11235:11235:0530/094525.762341:FATAL:overscroll_window_animation.cc(117)] Check failed: overscroll_source_ == OverscrollSource::NONE (2 vs. 0) #0 0x55d71a6125bc base::debug::StackTrace::StackTrace() #1 0x55d71a62af81 logging::LogMessage::~LogMessage() #2 0x55d718e6bc33 content::OverscrollWindowAnimation::OnOverscrollModeChange() #3 0x55d718e89139 content::WebContentsViewAura::OnOverscrollModeChange() #4 0x55d718d58f61 content::OverscrollController::ProcessOverscroll() #5 0x55d718d58cdd content::OverscrollController::ReceivedEventACK() #6 0x55d718d85392 content::RenderWidgetHostImpl::OnGestureEventAck() #7 0x55d718cf6ad7 content::GestureEventQueue::ProcessGestureAck() #8 0x55d718cfb75d content::InputRouterImpl::ProcessInputEventAck() #9 0x55d718cfa422 content::InputRouterImpl::OnInputEventAck() #10 0x55d718cfa27e _ZN3IPC8MessageTI38InputHostMsg_HandleInputEvent_ACK_MetaSt5tupleIJN7content13InputEventAckEEEvE8DispatchINS3_15InputRouterImplES8_vMS8_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #11 0x55d718cf9d9a content::InputRouterImpl::OnMessageReceived() #12 0x55d718d7c116 content::RenderWidgetHostImpl::OnMessageReceived() #13 0x55d718d65a8f content::RenderProcessHostImpl::OnMessageReceived() #14 0x55d71abf2851 IPC::ChannelProxy::Context::OnDispatchMessage() #15 0x55d71899eea3 _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN7content20BrowserMessageFilter8InternalEFbRKN3IPC7MessageEEEEJ13scoped_refptrIS6_ES8_EEEFvvEE3RunEPNS0_13BindStateBaseE #16 0x55d718471089 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #17 0x55d71a6bff44 base::debug::TaskAnnotator::RunTask() #18 0x55d71a6329b9 base::MessageLoop::RunTask() #19 0x55d71a632c7b base::MessageLoop::DeferOrRunPendingTask() #20 0x55d71a63307d base::MessageLoop::DoWork() #21 0x55d71a6355f9 base::MessagePumpLibevent::Run() #22 0x55d71a63263b base::MessageLoop::Run() #23 0x55d71a65b60a base::RunLoop::Run() #24 0x55d71a1e97ab ChromeBrowserMainParts::MainMessageLoopRun() #25 0x55d718a79157 content::BrowserMainLoop::RunMainMessageLoopParts() #26 0x55d718a7be36 content::BrowserMainRunnerImpl::Run() #27 0x55d718a747af content::BrowserMain() #28 0x55d71a1bbebc content::ContentMainRunnerImpl::Run() #29 0x55d71a1df879 service_manager::Main() #30 0x55d71a1baae4 content::ContentMain() #31 0x55d71845465f ChromeMain #32 0x7fdf1f15df45 __libc_start_main #33 0x55d7184544be <unknown>
,
Jun 5 2017
still happens to me using a goobuntu build
,
Jun 5 2017
Interesting.. Is there anything special you are doing? How many pages in history do you have? How quickly do you swipe? How often does it happen?
,
Jun 5 2017
so it's happening when a slide is cancelled, CancelSlide animates the layers, and then another OnOverscrollModeChange can come in before the cancellation animation is finished. This is easier to trigger if you make the animation take longer, like 3 seconds. Then after cancelling a slide, you will have 3 seconds where any other slide will hit this check.
,
Jun 5 2017
Got it to reproduce, thanks!
,
Nov 16 2017
This has been patched up in https://codereview.chromium.org/2985543002/ (linked it to the wrong bug). The "proper" fix is in https://codereview.chromium.org/2983883002/, but it probably doesn't make sense to land it if the issue does not reproduce with the new UI and we are enabling the new UI.
,
Dec 13 2017
,
Sep 28
,
Dec 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac3bb2923c432a36c23bee282c551192db29be33 commit ac3bb2923c432a36c23bee282c551192db29be33 Author: Mohsen Izadi <mohsen@chromium.org> Date: Sat Dec 22 00:48:07 2018 Removed parallax overscroll code The parallax overscroll mode is deprecated and the flag to enable it is already removed in M72. This CL removes unused code for this mode. BUG= 890390 , 357311 , 399676 , 405945 , 705599 , 701801 , 727718 Change-Id: I8ab710635e0291dacd8aacdd76c45ffeaf2fac7b Reviewed-on: https://chromium-review.googlesource.com/c/1273609 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#618693} [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/BUILD.gn [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay.h [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation.h [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_animation_unittest.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate.h [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/shadow_layer_delegate.cc [delete] https://crrev.com/3c771ad0370b97b75b8b623ea301ceb0a44a5208/content/browser/web_contents/aura/shadow_layer_delegate.h [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura.h [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura_browsertest.cc [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/browser/web_contents/web_contents_view_aura_unittest.cc [modify] https://crrev.com/ac3bb2923c432a36c23bee282c551192db29be33/content/test/BUILD.gn
,
Dec 22
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mfomitchev@chromium.org
, Jun 5 2017