New issue
Advanced search Search tips

Issue 727717 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression

Blocking:
issue 728343



Sign in to add a comment

gclient sync -r failing for some revisions

Reported by shockwav...@gmail.com, May 30 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
create Dockerfile with content:

```
FROM ubuntu:latest

RUN apt-get update && apt-get -y install git \
                                         pkg-config \
                                         python
WORKDIR /root
RUN git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
ENV PATH "$PATH:/root/depot_tools"
RUN fetch v8
RUN gclient sync -r 4.10.253
CMD bash
```

What is the expected behavior?
gclient sync -r 4.10.253 should finished successfully

What went wrong?
v8/buildtools (ERROR)                                                                                                                                                
----------------------------------------                                                                                                                             
[0:00:16] Started.                                                                                                                                                   
_____ v8/buildtools at ef3e530703353ba8ad094694ba7c156daddbddeb                                                                                                      
----------------------------------------                                                                                                                             
Traceback (most recent call last):                                                                                                                                   
  File "/root/depot_tools/gclient.py", line 2295, in <module>                                                                                                        
    sys.exit(main(sys.argv[1:]))                                                                                                                                     
  File "/root/depot_tools/gclient.py", line 2281, in main                                                                                                            
    return dispatcher.execute(OptionParser(), argv)                                                                                                                  
  File "/root/depot_tools/subcommand.py", line 252, in execute                                                                                                       
    return command(parser, args[1:])                                                                                                                                 
  File "/root/depot_tools/gclient.py", line 2030, in CMDsync                                                                                                         
    ret = client.RunOnDeps('update', args)                                                                                                                           
  File "/root/depot_tools/gclient.py", line 1340, in RunOnDeps                                                                                                       
    work_queue.flush(revision_overrides, command, args, options=self._options)                                                                                       
  File "/root/depot_tools/gclient_utils.py", line 1047, in run                                                                                                       
    self.item.run(*self.args, **self.kwargs)                                                                                                                         
  File "/root/depot_tools/gclient.py", line 766, in run                                                                                                              
    self.ParseDepsFile()                                                                                                                                             
  File "/root/depot_tools/gclient.py", line 562, in ParseDepsFile                                                                                                    
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)                                                                                            
  File "/root/depot_tools/gclient_eval.py", line 236, in Check                                                                                                       
    result_scope = _gclient_exec(content, global_scope, filename=path)                                                                                               
  File "/root/depot_tools/gclient_eval.py", line 181, in _gclient_exec
    _visit_in_module(stmt)
  File "/root/depot_tools/gclient_eval.py", line 165, in _visit_in_module
    value = _gclient_eval(node.value, global_scope, filename=filename)
  File "/root/depot_tools/gclient_eval.py", line 142, in _gclient_eval
    return _convert(node_or_string)
  File "/root/depot_tools/gclient_eval.py", line 141, in _convert
    getattr(node, 'lineno', '<unknown>')))
ValueError: unexpected AST node: <_ast.Num object at 0x7f0c416d7950> Num(n=1) (file '/root/v8/buildtools/DEPS', line 1)

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 
Flash Version:
 
We're seeing this on all 58.0.3029.110 builds starting early May 30th.

21:38:05 src/third_party/skia (ERROR)
21:38:05 ----------------------------------------
21:38:05 [0:00:08] Started.
21:38:05 [0:00:11] From https://skia.googlesource.com/skia
21:38:05 [0:00:11]    b365cf5..b5e4842  master     -> origin/master
21:38:05 [0:00:18] Up-to-date; skipping checkout.
21:38:05 _____ src/third_party/skia at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4
21:38:05 ----------------------------------------
21:38:05 Traceback (most recent call last):
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 2295, in <module>
21:38:05     sys.exit(main(sys.argv[1:]))
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 2281, in main
21:38:05     return dispatcher.execute(OptionParser(), argv)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/subcommand.py", line 252, in execute
21:38:05     return command(parser, args[1:])
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 2030, in CMDsync
21:38:05     ret = client.RunOnDeps('update', args)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 1340, in RunOnDeps
21:38:05     work_queue.flush(revision_overrides, command, args, options=self._options)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient_utils.py", line 1047, in run
21:38:05     self.item.run(*self.args, **self.kwargs)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 766, in run
21:38:05     self.ParseDepsFile()
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient.py", line 562, in ParseDepsFile
21:38:05     gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient_eval.py", line 240, in Check
21:38:05     result_scope = _gclient_exec(content, global_scope, filename=path)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient_eval.py", line 185, in _gclient_exec
21:38:05     _visit_in_module(stmt)
21:38:05   File "/var/jenkins/workspace/build_chromium/chromium/depot_tools/gclient_eval.py", line 181, in _visit_in_module
21:38:05     getattr(node, 'lineno', '<unknown>')))
21:38:05 ValueError: unexpected AST node: <_ast.Import object at 0x7ff0c7fdc3d0> Import(names=[alias(name='os', asname=None)]) (file '/var/jenkins/workspace/build_chromium/chromium/src/third_party/skia/DEPS', line 53)

Comment 2 by hmchen@chromium.org, May 31 2017

Blocking: 728343
This is due to https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/gclient$20DEPS%7Csort:date/chromium-dev/S-CijIGMw5M/haZ4G6PYBwAJ. We've worked around it by adding --disable-syntax-validation as suggested in that thread.
Mergedinto: 728343
Status: Duplicate (was: Unconfirmed)
But https://bugs.chromium.org/p/chromium/issues/detail?id=728343 seems private :( 
"You do not have permission to view the requested page. "
Problem seems to be gone by now

Sign in to add a comment