New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727692 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

memory-infra should report allocated_objects_size for java_heap

Project Member Reported by primiano@chromium.org, May 30 2017

Issue description

Looks like the outer size grows as a step function in O(MB) chunks, which quite useless.
I think we should make the size == today's allocated_object_size as that maps the actual code demands and use that in telemetry.

ssid/dskiba/mariakhomenko: opinions?

 
The advantage of our current java_heap value is that regressions are very visible. But I also like the idea of displaying just the allocated_objects_size because that's the thing we have control over.

I suspect the latter should be sufficient to notice regressions as well -- considering I'd expect Android implementation of VM not to change TOO often.
I guess the only case I can think of is: if we allocate and free large number of objects creating fragmentation more than we did before, that would be caught by the former but not the latter.

On the other hand, the step function growth can also mask more objects being allocated more efficiently. ¯\_(ツ)_/¯
> I guess the only case I can think of is: if we allocate and free large number of objects creating fragmentation more than we did before, that would be caught by the former but not the latter.

Yeah but IIRC ART has a moving GC, so at some point the situation should normalize.

The proble of the step function is that blames just *some* people who cross the step and hides most of other ones.

Comment 4 by ssid@chromium.org, May 31 2017

I like the idea of changing it to allocated_objects_size. We should definitely not stick to the step function. Also can we just turn on altering for the java_heap:allocated_objects_size ?

Sign in to add a comment