all CrOS bots failing in SyncChrome stage |
|||||||
Issue description
pretty much all CrOS bots are now red with:
Traceback (most recent call last):
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 2295, in <module>
sys.exit(main(sys.argv[1:]))
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 2281, in main
return dispatcher.execute(OptionParser(), argv)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/subcommand.py", line 252, in execute
return command(parser, args[1:])
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 2030, in CMDsync
ret = client.RunOnDeps('update', args)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 1340, in RunOnDeps
work_queue.flush(revision_overrides, command, args, options=self._options)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient_utils.py", line 1047, in run
self.item.run(*self.args, **self.kwargs)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 766, in run
self.ParseDepsFile()
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient.py", line 562, in ParseDepsFile
gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/gclient_eval.py", line 240, in Check
_GCLIENT_SCHEMA.validate(result_scope)
File "/b/build/slave/chromiumos-sdk/build/depot_tools/third_party/schema/schema.py", line 254, in validate
raise SchemaError([k] + x.autos, [e] + x.errors)
third_party.schema.schema.SchemaError: Key 'recursedeps' error:
Or(Optional(Or(<type 'basestring'>, (<type 'basestring'>, <type 'basestring'>)))) did not validate ['src/third_party/angle', 'DEPS.chromium']
Or(<type 'basestring'>, (<type 'basestring'>, <type 'basestring'>)) did not validate ['src/third_party/angle', 'DEPS.chromium']
['src/third_party/angle', 'DEPS.chromium'] should be instance of 'tuple'
https://uberchromegw.corp.google.com/i/chromiumos/waterfall
,
May 30 2017
Looks like a fallout of: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/infra-announce/GcuGYoPyASY/qrLCbUPCBQAJ The stated workaround is to pass --disable-syntax-validation
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/05fec0394f8eec6e2a3c53f9c34a079640e8cffe commit 05fec0394f8eec6e2a3c53f9c34a079640e8cffe Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Tue May 30 21:20:36 2017 gclient: fix recursedeps tuple/list validation for chromeos Bug: 727685 , 570091 Change-Id: I97a99d15930c1662c0ecfacd3755af27b282f686 Reviewed-on: https://chromium-review.googlesource.com/517800 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/05fec0394f8eec6e2a3c53f9c34a079640e8cffe/gclient_eval.py [modify] https://crrev.com/05fec0394f8eec6e2a3c53f9c34a079640e8cffe/tests/gclient_eval_unittest.py
,
May 30 2017
Where are we seeing this failure in ChromeOS? Am I correct in the belief that #3 will not help us until it has been uprevved by the chrome pfq? If so, and if this breakage was introduced to ChromeOS by a pfq uprev, then we should pin chrome back to prior to the breakage.
,
May 30 2017
,
May 30 2017
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/67492fd496629e167c01efc2aa472ad7b3cfb533 commit 67492fd496629e167c01efc2aa472ad7b3cfb533 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Tue May 30 21:32:18 2017 Roll depot_tools 1101645..05fec03 05fec039 gclient: fix recursedeps tuple/list validation for chromeos TBR=dpranke Bug: 727685 , 570091 Change-Id: I3e479ac9a16384a9aeaf9e8383c685fca33063e2 Reviewed-on: https://chromium-review.googlesource.com/517956 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/67492fd496629e167c01efc2aa472ad7b3cfb533/infra/config/recipes.cfg
,
May 30 2017
FWIW looks like https://uberchromegw.corp.google.com/i/chromiumos/builders/amd64-generic-asan/builds/20088 is now past the SyncChrome error.
,
May 30 2017
,
May 30 2017
iirc, SyncChrome stage uses depot_tools outside of the chroot that is available on the build bots, so it's not affected by the pinned versions in our manifest
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by phajdan.jr@chromium.org
, May 30 2017Status: Started (was: Untriaged)