Analyze didn't detect ios_chrome_unittests needed to run |
||||||||
Issue descriptionWhen https://codereview.chromium.org/2910983002 was relanded (reusing the same CL), trybots executed for PS#2 but they didn't detect that ios_chrome_unittests needed to run so the test was skipped. This led to many breakages post-commit on several builders, one example being https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/17967 I think the reason for this is that the case changes in components/browsing_data_strings.grdp doesn't trigger analyze (it only looks at files tracked by GN) so only the tests affected by the unit test changes were run. Please investigate more before relanding the CL again.
,
May 31 2017
The cl was relanded successfully. The issue was that dependencies of string changes are not detected, so tests are skipped.
,
May 31 2017
Changing some strings in http://crrev.com/2910983002 caused two reverts because there were tests that checked for these strings. The trybots skipped all unit_tests because they didn't understand the dependency between the tests and these strings. It would be great if we could prevent this in the future. Is it possible to declare a dependency of a build target on a .grdp file, so that e.g. everything, that depends on components/browsing_data/content would be tested if we change browsing_data_strings.grdp?
,
May 31 2017
The ios-simulator is red most of the time ios_chrome_unittests needs to run and is timing out. Is that related? That's near-P0 for V8 as it blocks rolling. E.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227138 https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227140
,
May 31 2017
I don't think that is related to my CL. When it caused a failure, it explicitly failed a test and didn't time out: https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/17967 Also the affected test (ClearBrowsingDataCollectionViewControllerTest.TestCacheCounterFormattingForLessThanAllTime) ran successfully in the build that timed out for you.
,
May 31 2017
Thanks, will file a separate issue.
,
May 31 2017
,
Dec 22 2017
,
Dec 22 2017
Moved all Infra>Client>iOS bugs to Infra>Client>Chrome + OS-iOS.
,
Dec 22 2017
Can you investigate to see if this is still relevant?
,
Jun 20 2018
I don't believe it's relevant anymore, archiving. If anyone thinks otherwise, please reopen and explain why. I also don't believe it's an infrastructure issue, since the request in #c3 is to update the build dependencies. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dullweber@chromium.org
, May 30 2017