Issue metadata
Sign in to add a comment
|
Regression: Unnecessary omnibox URL gets selected on using alt+tab |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.7 dev OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and open any webpage[ex: F1 for help page] >> Select entire URL present in Omnibox (2)Now click on wrench menu >> More tools >> Add to desktop so that name in the overlay gets selected (3)Hit Alt+tab to move focus to other window and again hit Alt+tab to bring focus back >> Now observe focus Expected: Focus should not be seen both on omnibox and overlay. Actual: Instead both omnibox URL and name on add to desktop overlay is highlighted. This is a regression issue broken in M56. Good Build: 56.0.2897.0 dev Bad Build: 56.0.2899.0 dev NOTE: Issue is not seen in Windows
,
May 30 2017
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Canary-61.0.3115.0. Manual Bisect info: ------------------ Good Build: 56.0.2897.0-Revision-426673 Bad Build: 56.0.2899.0-Revision-426989 Per revision bisect info: ------------------------ You are probably looking for a change made after 426904 (known good), but no later than 426905 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b07f20559996aa8154a3a67e742676a9799e37c4..5c16e0e849526c1c627e08a05351ab38a9cfbcf1 Review-Url: https://chromiumcodereview.appspot.com/2371113003 warx@, Please take a look and reassign to the right owner if it is not related to your change. Thanks..!!
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81ead2ab2380d5f624b9ce63df050a76de134f06 commit 81ead2ab2380d5f624b9ce63df050a76de134f06 Author: warx <warx@chromium.org> Date: Fri Jun 02 23:53:52 2017 desktop_aura: do not restore focused view if it has modal transient child Changes: RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated. BUG= 727641 TEST=emulator test saw bug fixed and added test coverage Review-Url: https://codereview.chromium.org/2919973002 Cr-Commit-Position: refs/heads/master@{#476835} [modify] https://crrev.com/81ead2ab2380d5f624b9ce63df050a76de134f06/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/81ead2ab2380d5f624b9ce63df050a76de134f06/ui/views/widget/widget_interactive_uitest.cc
,
Jun 2 2017
fixed on M-61
,
Jun 2 2017
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a796415316eb8e7c8a6f1e746b837f8f24a60382 commit a796415316eb8e7c8a6f1e746b837f8f24a60382 Author: blundell <blundell@chromium.org> Date: Mon Jun 05 10:55:53 2017 Revert of desktop_aura: do not restore focused view if it has modal transient child (patchset #3 id:40001 of https://codereview.chromium.org/2919973002/ ) Reason for revert: The newly-added test is flaky: https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBXaWRnZXRUZXN0SW50ZXJhY3RpdmUuRGVza3RvcE5hdGl2ZVdpZGdldFdpdGhNb2RhbFRyYW5zaWVudENoaWxkDA Reverting the CL rather than disabling the test as it's not clear where the flake is coming from: is it a problem in the test or in the production code added in this CL? Original issue's description: > desktop_aura: do not restore focused view if it has modal transient child > > Changes: > RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated. > > BUG= 727641 > TEST=emulator test saw bug fixed and added test coverage > > Review-Url: https://codereview.chromium.org/2919973002 > Cr-Commit-Position: refs/heads/master@{#476835} > Committed: https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df050a76de134f06 TBR=sky@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 727641 Review-Url: https://codereview.chromium.org/2921253002 Cr-Commit-Position: refs/heads/master@{#476970} [modify] https://crrev.com/a796415316eb8e7c8a6f1e746b837f8f24a60382/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/a796415316eb8e7c8a6f1e746b837f8f24a60382/ui/views/widget/widget_interactive_uitest.cc
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce9f58e951b6b5328e5517d425a2a76350cfd2cf commit ce9f58e951b6b5328e5517d425a2a76350cfd2cf Author: warx <warx@chromium.org> Date: Mon Jun 05 21:22:52 2017 [Reland] desktop_aura: do not restore focused view if it has modal transient child Reland changes: Disable the test coverage on OS_WIN for now, so that further investigation can be done separately. Changes: RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated. BUG= 727641 TEST=emulator test saw bug fixed and added test coverage Review-Url: https://codereview.chromium.org/2919973002 Cr-Commit-Position: refs/heads/master@{#476835} Committed: https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df050a76de134f06 patch from issue 2919973002 at patchset 40001 (http://crrev.com/2919973002#ps40001) Review-Url: https://codereview.chromium.org/2918343003 Cr-Commit-Position: refs/heads/master@{#477087} [modify] https://crrev.com/ce9f58e951b6b5328e5517d425a2a76350cfd2cf/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/ce9f58e951b6b5328e5517d425a2a76350cfd2cf/ui/views/widget/widget_interactive_uitest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, May 30 2017