Issue metadata
Sign in to add a comment
|
11.5% regression in media.android.tough_video_cases_tbmv2 at 474770:474884 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 30 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8978177633238083920
,
May 30 2017
=== Auto-CCing suspected CL author fsamuel@chromium.org === Hi fsamuel@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : fsamuel Commit : d71466ad118aca05aa347c9766f80a5f77528588 Date : Thu May 25 20:35:22 2017 Subject: cc::SurfaceDependencyTracker should not crash when a Display goes away Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : media.android.tough_video_cases_tbmv2 Metric : cpu_time_percentage_avg/video.html?src_tulip2.ogg_type_audio Change : 4.30% | 0.232138024131 -> 0.241169562858 Revision Result N chromium@474769 0.232138 +- 0.0148999 9 good chromium@474777 0.234495 +- 0.0118076 9 good chromium@474781 0.233706 +- 0.00584777 6 good chromium@474782 0.23329 +- 0.0100505 6 good chromium@474783 0.242103 +- 0.00813427 6 bad <-- chromium@474784 0.241642 +- 0.0162489 9 bad chromium@474798 0.240417 +- 0.00555076 6 bad chromium@474827 0.241869 +- 0.00568495 6 bad chromium@474884 0.24117 +- 0.00848798 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.ogg.type.audio media.android.tough_video_cases_tbmv2 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8978177633238083920 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5627096514166784 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 30 2017
Issue 727502 has been merged into this issue.
,
May 30 2017
,
May 30 2017
As of this CL, this should now be fixed: https://codereview.chromium.org/2887453002/ Does this need a merge?
,
May 30 2017
it looks like the original commit was included in the M60 branch, so a merge sounds like the right move.
,
May 30 2017
Please tag with appropriate OSs. Thanks.
,
May 31 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by toyoshim@chromium.org
, May 30 2017