ios_chrome_unittests broken by change in SnapshotCache |
|||||||
Issue descriptionThe following tests fails with the latest roll: TabOpenAppOffTheRecordTest.testDummyURL TabModelTest.CloseAllTabs TabOpenAppTest.testDummyURL ClearBrowsingDataCollectionViewControllerTest.TestCacheCounterFormattingForAllTime TabModelTest.OpenersNothingOpenedFirst TabModelTest.InsertUrlSingle TabModelTest.AppendUrlSingle TabModelTest.OpenersChildTabBeforeOpener TabModelTest.PersistSelectionChange TabTest.GetSuggestedFilenameFromURL TabModelTest.ParentTabModel TabModelTest.RestoreSessionOn2NtpTest TabModelTest.OpenerOfTab SnapshotCacheTest.GreyImageAllInBackground TabModelTest.AddWithOrderController SnapshotCacheTest.SaveToDisk TabModelTest.CloseTabAtIndexOnlyOne SnapshotCacheTest.HandleMemoryWarning TabModelTest.AddWithLinkTransitionAndIndex TabModelTest.CloseTabAtIndexMiddle SnapshotCacheTest.DeleteRetinaImages TabTest.FailToOpenAppSettings https://uberchromegw.corp.google.com/i/internal.bling.main/builders/chromium-autoroller/builds/1140 Looks like there is a NULL pointer that is dereferenced when looking at the crash logs: [ RUN ] TabOpenAppOffTheRecordTest.testDummyURL Received signal 11 SEGV_MAPERR 000000000024 [0x00010f1885ad] [0x00010f1885ed] [0x00010f1872fc] [0x00010f1884d6] [0x0001236dc52a] [0x7fff526a4e10] [0x00010f34fbb0] [0x00010e910b19] [0x00010e91eebd] [0x00010eb4dad6] [0x00010df526de] [0x00010df3a6f0] [0x00010df3bcb5] [0x00010df3bcf9] [0x00010d7fab90] [0x00010dce8c8e] [0x00010dcc44d2] [0x00010dcc444b] [0x00010dcc54ad] [0x00010dcc674c] [0x00010dcd34f9] [0x00010dcebe7e] [0x00010dcd3112] [0x00010dcd300a] [0x00010f506b21] [0x00010f505fbb] [0x00010f50a121] [0x00011c676f48] [0x00011b871964] [0x00011b8715f3] [0x00011b87117a] [0x00011b868f01] [0x00011b868494] [0x000120ec0a6f] [0x000119f9ff34] [0x00010f50a3c2] [0x00010f505e9f] [0x00010d54c825] [0x00010d54c764] [0x00010d54c715] [0x00010d54c62c] [0x00010f50c2fd] [0x00010f50c27c] [0x00010d54c392] [0x00012339168d] [end of stack trace]
,
May 30 2017
Should be fixed once https://codereview.chromium.org/2910183002/ lands (revert of the CL introducing the leaky base::SequencedTaskRunner). Re-assigning to sheriff as they are in the office now.
,
May 30 2017
Need reverting an additional CL, thus https://codereview.chromium.org/2915583002/ needs to land first.
,
May 30 2017
In that the upstream bots are also broken, so removing RVG and reverting the third CL (in base) that has to be reverted to fix the bots.
,
May 30 2017
,
May 30 2017
There's a third CL that need to be rolled back https://codereview.chromium.org/2912073002/, should be the last one in the sequence.
,
May 30 2017
Sylvain, please fill Component field if you Assigning the bug.
,
May 31 2017
,
May 31 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sdefresne@chromium.org
, May 30 2017