Modify "add extension" dialogs to not do crazy column layouts |
||||||
Issue descriptionChrome Version: 60.0.3112.7 dev OS: Ubuntu 14.04,Windows Pre-Condition: Enable Material Design in the rest of the browser's native UI flag from chrome://flags What steps will reproduce the problem? (1)Launch chrome and go to webstore and try adding any extension [say https://chrome.google.com/webstore/detail/office-online/ndjpnladcallmjemlbaebfadecfhkepb?hl=en-GB ] (2)Click on "Add to chrome" and observe overlay Expected: Overlay should be as expected. Actual: Instead font size is seen enlarged and unwanted space is seen on right of overlay. This is a regression issue broken in M60. Good Build: 60.0.3080.0 dev Bad Build: 60.0.3081.0 dev
,
May 30 2017
Using the per-revision bisect providing the bisect results, Good build:60.0.3080.0(Revision:466837). Bad build:60.0.3081.0(Revision:467177). You are probably looking for a change made after 467030 (known good), but no later than 467031 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/aeb180b1bc8066c2095c124d55e744be0124f020..ce9d455e92cf41f171d31093cee055e41d634ea9 From the CL above, assigning the issue to the concern owner @ellyjones: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2821413002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3115.0
,
May 31 2017
Dropping priority & marking as regular bug: This isn't a regression, because Harmony has not shipped and it only appears with Harmony enabled. It is not Pri-1 for the same reason. This is caused by the new Harmony width snapping for that dialog. The width snapping code is working as designed. The dialog's implementation is doing the wrong thing, though: it creates some columns of fixed widths that happen to add up to a bit more than a Harmony layout breakpoint and the dialog gets snapped to the next point up. I suspect the dialog will need some reworking to have a sensible layout; in general dialogs should not be doing layout this way. pkasting@, do you know who might have cycles to look at this dialog? the code for it is quite messy since this is actually five or six separate dialogs in one class.
,
May 31 2017
I think it's actually assigned to you at the moment via bug 605657 , but I suspect we'll want to have someone else tackle this.
,
Jun 1 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Obsolete; I redid the layout earlier this year. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kavvaru@chromium.org
, May 30 2017Status: Untriaged (was: Unconfirmed)