Issue metadata
Sign in to add a comment
|
Regression: Unwanted space is seen between Apps icon and Apps text |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.7 dev OS: Ubuntu 14.04,Windows Pre-Condition: Enable Material Design in the rest of the browser's native UI flag from chrome://flags What steps will reproduce the problem? (1)Launch chrome and observe unwanted space between apps icon and apps text on bookmark bar Expected: No such spacing should be seen between icon and text. Actual: Instead unwanted space is seen between apps icon and "Apps" text. This is a regression issue broken in M60. Good Build: 59.0.3071.0 dev Bad Build: 59.0.3072.0 dev NOTE: This spacing is seen for all bookmarked pages on bookmark bar as well
,
May 30 2017
Able to reproduce the issue on 60.0.3112.7 & 61.0.3115.0 on Linux Ubuntu 14.04. Looks fine on Mac OS 10.12.4 on the latest canary(61.0.3115.0).
,
May 30 2017
Using the per-revision bisect providing the bisect results, Good build:59.0.3071.0 -(Revision:464641). Bad build: 60.0.3072.0 -(Revision:464836). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/03e181ac938ea7034d4f983327f1b71e85549f9e..d61d7204eab9c8d63173a8fbadeaac9a2e816fae Review-Url: https://codereview.chromium.org/2818123002 kylixrd@ Could you please look into this issue and please help us to assign this issue to the right owner if not respect to your change. Thanks.
,
Jun 13 2017
,
Jun 13 2017
Am able to reproduce the behavior on 59.0.3071.86 x64 (STABLE) / Windows 10 x64 10.0.15063. chrome://flags/#secondary-ui-md is disabled by default; tinkering with it doesn't change a thing.
,
Jun 13 2017
I'm not seeing this on 59.0.3071.86. I see no change in the spacing between setting or resetting chrome://flags/#secondary-ui-md. I do, however see this on the Canary (daily) build and changing chrome://flags/#secondary-ui-md does, in fact, change the spacing... It changes between the correct 8 dip/pixels to the incorrect 16 dip/pixels. The actual solution is going to be to maintain a fixed spacing regardless of that flag.
,
Jun 13 2017
Any further info I can provide y'all with? It definitely manifests itself in the stable build (59.0.3071.86) on my Windows setup, I'm not seeing things. The double spacing (16 vs 8) is definitely noticeable and visible as day; my rightmost bookmark in the bookmark bar plain disappeared behind the "see more" arrows. Screenshot attached: https://i.imgur.com/jWgbFNU.png
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/364085c6913c4b0ce05866f21a99c9dab8731566 commit 364085c6913c4b0ce05866f21a99c9dab8731566 Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Jun 14 13:18:41 2017 Explicitly set the image label spacing for the buttons on the bookmarks bar. Bug: 727606 Change-Id: Iea519395d402dfb679ac05cfa7377476d5db7c8e Reviewed-on: https://chromium-review.googlesource.com/531628 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#479365} [modify] https://crrev.com/364085c6913c4b0ce05866f21a99c9dab8731566/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/364085c6913c4b0ce05866f21a99c9dab8731566/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc [modify] https://crrev.com/364085c6913c4b0ce05866f21a99c9dab8731566/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/364085c6913c4b0ce05866f21a99c9dab8731566/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/364085c6913c4b0ce05866f21a99c9dab8731566/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
,
Jun 14 2017
The spacing now should be 8 dip regardless of the secondary-ui-md setting.
,
Jun 15 2017
Same behavior between 59.0.3071.86 (https://i.imgur.com/jWgbFNU.png) and today's official 59.0.3071.104 (https://i.imgur.com/ruR1Pmh.png). Was the labeling issue supposed to be addressed? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, May 30 2017