New issue
Advanced search Search tips

Issue 727580 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

add a compile-only bot to chromium's CQ that uses the previous canary's V8 rev

Project Member Reported by jochen@chromium.org, May 30 2017

Issue description

so developers don't accidentally add uses of V8's API without waiting for a canary first
 
The ref already exists:
https://chromium.googlesource.com/v8/v8/+/canary

It is updated by an internal builder:
https://uberchromegw.corp.google.com/i/internal.client.v8/builders/v8_canary_detector

The bot is not using what is actually pushed out, i.e. what omahaproxy would show, but the latest candidate. That's usually a good approximation.

Adding such a builder to chromium shouldn't be too hard, but this might additionally require:
- Better documentation and maintenance of the canary ref updater. If it breaks, troopers need to know what to do.
- A corresponding CI bot. One exists, but in V8 territory:
https://build.chromium.org/p/client.v8.chromium/builders/Linux%20V8%20API%20Stability

Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by jochen@chromium.org, May 30 2017

Components: Infra>Client>V8 Infra>Platform>Buildbot>TryServer

Comment 4 by no...@chromium.org, Jun 16 2018

Components: -Infra>Platform>Buildbot>TryServer

Sign in to add a comment