New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727553 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 727551



Sign in to add a comment

Add syntax highlighting for mojom in various editors

Project Member Reported by blundell@chromium.org, May 30 2017

Issue description

Relevant info from scottmg@:

"Re: syntax, assuming you're using the right editor, apparently I made this a while ago https://cs.chromium.org/chromium/src/tools/vim/mojom/syntax/mojom.vim. It might need a bit of updating."

(Note that I left in the editorial slant as I agree with it ;).
 
Cc: michae...@chromium.org
Vim updates: https://chromium-review.googlesource.com/c/chromium/src/+/722122

Before/after screenshots attached.
before.png
37.9 KB View Download
after.png
38.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43024fcc0c4c3702b8af3be0817ad075fc98088f

commit 43024fcc0c4c3702b8af3be0817ad075fc98088f
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Oct 17 02:57:18 2017

Improve mojom syntax highlighting in Vim

Add missing keywords, literals, and attributes. Clean up the vimscript a
bit.

The file still does not conform to the Google style guide, but I wanted
to keep these changes minimal.

Before/after screenshots: see bug.
Text for testing: https://pastebin.com/raw/xAxJ5LvH

Bug: 727553

Change-Id: I2e3519514c30bb627b825861d722edba91c824de
Reviewed-on: https://chromium-review.googlesource.com/722122
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509249}
[modify] https://crrev.com/43024fcc0c4c3702b8af3be0817ad075fc98088f/tools/vim/mojom/syntax/mojom.vim

Project Member

Comment 3 by sheriffbot@chromium.org, Oct 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -roc...@chromium.org rockot@google.com
Status: Available (was: Untriaged)

Sign in to add a comment