Xiyuan, could you advise on the question in the OP? Thanks in advance!

+rkc

If //components/signin does not need AccountId, we could move it to //components/user_manager/public (/cpp for c++ and /interfaces for mojo). //ash uses AccountId but not user_manager, so it needs to be a new build target.

This is not really ARC specific though.

We probably want AccountId (and likely known_users) to be available for other platforms. We can create components/account_id , WDYT?

Thanks for the responses!

It's unclear to me what the relationship is between AccountId (the one being discused in this bug), //components/signin's AccountInfo, and the notion of "accountID" that's broadly used within //components/signin (and by the Identity Service). Why would you foresee other platforms wanting to use AccountId, in particular rather than using the latter two concepts? 

I'm going to be in MTV in mid-April, so if it would be useful for us to discuss this question in person, I'd be happy to!

When Roger Tawa and me designed AccountId, the idea was if user can have several ways to be identified, we should have a structure that will have all of them and be used to identify users.

This structure is more important on the ChromeOS, where user is actually an OS user, and Chrome profile identification is not strictly tied to OS user (we enforce that, but technically these are different), and when OS user object lives longer than Chrome profile.

Another goal was to make it singleton-like, so that we only have it in memory once per user. This should not be enforced, so its copyable, but I tried to remove all the copying I could find.

So we should consider AccountId as a user identifier.

But code in components/signin is different. (I am not owner of components/signin, so this is only how I understand it.) components/signin is Google-only sign-in. It uses term "account_id" as Google account id, i.e. this is some blob-like identifier that is currently used to identify this user to Google. Internally code knows the type of this identifier, but the design was like "this is current Google account id as we use to talk to Google".

So when I was integrating AccountId, I renamed all strings like account_id everywhere outside of components/signin to make "account_id" always have AccountId type. But components/signin is different, so I left this part till the end of integration AccountId to the other parts of code.

I think it's up to the owners of components/signin whether to rename account_id to google_account_id to make grepping simpler, because I totally understand their reasoning to use account_id identifier.

That provides a ton of helpful context, thank you! I'm going to mull over that information and its implications for the Identity Service in particular.

My CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1036504

Gerrit is extremely slow with it, so be patient when opening this URL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f09a8fd0076d0c050de991d81fc9ddf1f849541

commit 3f09a8fd0076d0c050de991d81fc9ddf1f849541
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu May 03 02:52:10 2018

Create components/account_id/ .

This CL creates new component components/account_id/ by moving existing files
out of components/signin/.

Basically it moves:
 components/{signin/core => }/account_id/
 components/{signin/public => account_id}/interfaces/BUILD.gn

Most of the changes are purely mechanical:

git-gs 'include .components/signin/core/account_id/account_id.h' | sed 's/:.*$//' | xargs sed -i 's#components/signin/core/account_id/account_id.h#components/account_id/account_id.h#'

find . -mount -name DEPS | xargs sed -i 's#components/signin/core/account_id#components/account_id#'

find . -mount -name '*mojom' | xargs sed -i 's#components/signin/public/#components/account_id#'

find . -mount -name '*.gn' -type f | xargs sed -i 's#components/signin/core/account_id#components/account_id#'

components/account_id/DEPS was created manually be stripping all the extra
deps it had in components/signin/DEPS .

Bug:  727549 ,462823
Change-Id: I9c0752a0503affef87c032453b6b5023b41e8e77
Reviewed-on: https://chromium-review.googlesource.com/1036504
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555657}
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/BUILD.gn
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/DEPS
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/detachable_base/detachable_base_handler.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/detachable_base/detachable_base_handler_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/detachable_base/detachable_base_notification_controller_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/login/ui/fake_login_detachable_base_model.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/message_center/message_center_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/assistant_card_renderer.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/pref_connector.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/user_info.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/session/session_activation_observer_holder.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/session/session_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/shelf/app_list_button.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/shell_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/DEPS
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/user/tray_user.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/user/user_view.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/web_notification/inactive_user_notification_blocker.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/web_notification/inactive_user_notification_blocker.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/system/web_notification/inactive_user_notification_blocker_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/ash/test/ash_test_base.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_data.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_app_data.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_app_data_base.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_app_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/app_mode/startup_app_launcher_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/attestation/attestation_policy_observer.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/attestation/enrollment_policy_observer.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/extensions/wallpaper_api.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/extensions/wallpaper_private_api.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/file_system_provider/notification_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/auth/chrome_login_performer.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/lock_screen_utils.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/quick_unlock/pin_backend.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/quick_unlock/quick_unlock_factory.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/signin/token_handle_fetcher.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/signin/token_handle_util.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/ui/login_display_webui.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/user_flow.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/user_flow.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/users/affiliation.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/users/chrome_user_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/active_directory_policy_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/affiliation_test_helper.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/power_policy_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/power/power_prefs_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/printing/external_printers_factory.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/chromeos/profiles/profile_helper.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/drive/drive_notification_manager_factory_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/feedback/feedback_dialog_utils.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/notifications/profile_notification.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/cloud/user_policy_signin_service.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_attributes_storage_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_list_desktop_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/profiles/profile_window_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/chrome_screenshot_grabber_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/chrome_shell_content_state_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_util.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_util_chromeos_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/multi_user_window_manager_stub.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/test_multi_user_window_manager.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/test_multi_user_window_manager.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/session_controller_client_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/shelf_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/browser_finder.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/browser_finder_chromeos_unittest.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/3f09a8fd0076d0c050de991d81fc9ddf1f849541/chrome/browser/ui/views/frame/browser_non_client