New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727540 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

tune Chrome PFQ suite retries

Project Member Reported by ihf@chromium.org, May 30 2017

Issue description

Take a look at
https://viceroy.corp.google.com/chromeos/suite_details?job_id=120314388

1) JOB_RETRIES work for bvt-inline but not bvt-cq. Enable these.
2) It looks like we don't need 10 retries for the suite. I think 4 should be enough for most situations. 
 

Comment 1 by ihf@chromium.org, May 30 2017

Cc: nya@chromium.org achuith@chromium.org
Mhh, it should be noted that the two tests that were retried (security_ProfilePermissions, login_CryptohomeIncognito) each have JOB_RETRIES = 5 specified. I am not sure if that is really meaningful.

But I kinda sorta sense an arms race between gardeners and infra team here. Gardeners trying to find ways to retry, while infra trying to find ways to disable retries. Or am I interpreting this wrong?
I'm not sure that this is a gardner vs. infa thing per-se, it's just that retries are a double edged sword. On the one hand they help reduce flakiness, on the other hand they can mask real failures and increase load. 

Personally I think that any test that requires > 2 attempts is way too flaky and needs to be disabled or fixed.

It would be great to do an audit and document this somewhere (or better yet write a tool to generate the documentation).


Comment 3 by ihf@chromium.org, May 31 2017

It is just these two tests, all others have 2 or 0.
Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6ec709fd174e8ec4daaa2d1e6d666c952fca60ed

commit 6ec709fd174e8ec4daaa2d1e6d666c952fca60ed
Author: Ilja H. Friedel <ihf@google.com>
Date: Wed May 31 09:15:31 2017

Revert to 2 retries for CryptohomeIncognito & ProfilePermissions.

BUG=chromium:631640,  chromium:727540 
TEST=None.

Change-Id: Ib64b9f03a6392dc0bffc906fc29975467b5b984c
Reviewed-on: https://chromium-review.googlesource.com/518553
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/6ec709fd174e8ec4daaa2d1e6d666c952fca60ed/client/site_tests/login_CryptohomeIncognito/control
[modify] https://crrev.com/6ec709fd174e8ec4daaa2d1e6d666c952fca60ed/client/site_tests/security_ProfilePermissions/control

Comment 5 by ihf@chromium.org, Jun 2 2017

Cc: davidri...@chromium.org
Status: Fixed (was: Started)
David is limiting suite retries to 5 in issue 728738.
Marking this as fixed.

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment