Regression: Misalignment of button is observed for Bluetooth and USB bubble on https://permission.site/
Reported by
abom...@etouch.net,
May 30 2017
|
|||||
Issue descriptionChrome Version:60.0.3112.7 acf6afccbfe8fc0ddb9a616a6286f336e0204761-refs/branch-heads/3112@{#20} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) Pre-condition: 1. Enable #secondary-ui-md flag 2. Enable #enable-experimental-web-platform-features flag. What steps will reproduce the problem? 1. Launch chrome and navigate to https://permission.site/ 2. Click on ‘Bluetooth’ button or ‘Usb’ button and observe button present on the bubble. Actual:Misalignment of button is observed Expected: Misalignment should not be seen. This is regression issue, broken in ‘M 60’ and below is manual bisect: Good build:60.0.3109.0(474119) Bad build:60.0.3110.0(474499)
,
May 30 2017
I'll take a look.
,
Jun 6 2017
Thanks for the update. It would be great to have a fix ASAP. We will take only critical merges while close to Stable.
,
Jun 6 2017
,
Jun 6 2017
I'll write a fix today. It shouldn't take so long as to require a merge.
,
Jun 13 2017
Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version 61.0.3129.0 bsep@ Could you please look into this issue. Thanks
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02f8ec0767ac92101a2135f0f681528a16bda1ce commit 02f8ec0767ac92101a2135f0f681528a16bda1ce Author: bsep <bsep@chromium.org> Date: Wed Jun 14 02:09:30 2017 Fix Harmony popover buttons being flush with their content. When I wrote crrev.com/2888563004 I didn't realize that Harmony popover bubbles were relying on the special case in DialogClientView to space out their buttons and their content. This patch completely removes that special case and makes the spacing explicit. It also includes some minor opportunistic cleanup. BUG= 727520 Review-Url: https://codereview.chromium.org/2932523003 Cr-Commit-Position: refs/heads/master@{#479251} [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/chrome/browser/ui/views/harmony/harmony_layout_provider.cc [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/ui/views/bubble/bubble_dialog_delegate.cc [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/ui/views/layout/layout_provider.cc [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/ui/views/layout/layout_provider.h [modify] https://crrev.com/02f8ec0767ac92101a2135f0f681528a16bda1ce/ui/views/window/dialog_client_view.cc
,
Jun 14 2017
,
Jun 14 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 14 2017
This is behind a flag so there's no reason to merge it or block release.
,
Jun 20 2017
Tested the issue on Windows-10&7, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest Dev M61-61.0.3135.4 by following steps mentioned in the original comment. Observed that alignment of buttons are displaying as expected. Hence adding TE-Verified label. Please find the screen cast for reference. Thank you! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, May 30 2017Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)