Multiple calls to console.time() should not reset timer |
||||
Issue description
Chrome Version : 58.0.3029.110
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Safari: OK
Firefox: OK
Edge: OK
What steps will reproduce the problem?
Open up the DevTools and navigate to the console. Start a timer with an arbitrary label via `console.time("label")`. Wait a few seconds and run `console.time("label");console.timeEnd("label").
What is the expected result?
As the spec is making more explicit (see https://github.com/whatwg/console/pull/112), multiple calls to an existing timer should not reset the timer.
What happens instead?
The timer with label "label" gets reset when it should not have.
Please provide any additional information below. Attach a screenshot if
possible.
https://github.com/whatwg/console/pull/112
https://github.com/whatwg/console/issues/103
,
Jun 8 2017
This seems to be independent of OS, though I have tried it on 64-bit Ubuntu 16.04 as well as OSX Chrome version 58.
The screencast looks good to me. Basically if you call
`console.time('label')`
...and wait 5 seconds before calling `console.time('label');console.timeEnd('label')` an implementation that does not reset the timer on multiple calls to `console.time('label')` would print a time indicating 5 seconds have passed, but instead in your screencast you get a VERY small number of milliseconds, indicating that your second call to `console.time('label')` (right before your call to timeEnd) actually reset the timer associated with label `label`.
Try the same thing you did in the screencast, but on a different browser (Safari will suffice) and compare the results (i.e. drastic difference in outputted time). Let me know if you need anything else.
,
Jun 8 2017
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 17 2017
@luoe Not sure if this is actually a console issue or something on the V8 side - but either way, I think you'll be interested :)
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/135e5a98873351552d01931c97f03046fc7a566a commit 135e5a98873351552d01931c97f03046fc7a566a Author: Erik Luo <luoe@chromium.org> Date: Thu Nov 30 20:51:06 2017 Skip tests for console.time/count related V8 changes Bug: 700624 , 727514 Change-Id: I54f08aa19e76f505303b9314fa56d7deb3fcb348 Reviewed-on: https://chromium-review.googlesource.com/794490 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520672} [modify] https://crrev.com/135e5a98873351552d01931c97f03046fc7a566a/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a7469f71620aa241876bed601f931fcdbbec87e commit 4a7469f71620aa241876bed601f931fcdbbec87e Author: Erik Luo <luoe@chromium.org> Date: Fri Dec 01 03:47:32 2017 Skip another virtual test for V8 changes to console Also add rebased expectations in CL for reviewers. Bug: 700624 , 727514 Change-Id: I25b4194786b234f36618feac3df708253a5efde9 Reviewed-on: https://chromium-review.googlesource.com/802461 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520843} [modify] https://crrev.com/4a7469f71620aa241876bed601f931fcdbbec87e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/4a7469f71620aa241876bed601f931fcdbbec87e/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests-expected.txt [modify] https://crrev.com/4a7469f71620aa241876bed601f931fcdbbec87e/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a commit 3cfbcc725c2423a25b7c6986bdc127d2605c6a0a Author: Erik Luo <luoe@chromium.org> Date: Fri Dec 01 19:17:30 2017 Do not reset timer for console.time calls with the same label Similar to Firefox and Safari, calling console.time() repeatedly with the same label will now produce a console warning indicating that the label already exists. Similarly for console.timeEnd() as well. Bug: chromium:727514 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id644ee107b09e7f4686fff44c5f32d31c88371ad Reviewed-on: https://chromium-review.googlesource.com/794345 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49803} [modify] https://crrev.com/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a/src/inspector/v8-console-message.cc [modify] https://crrev.com/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a/src/inspector/v8-console-message.h [modify] https://crrev.com/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a/src/inspector/v8-console.cc [add] https://crrev.com/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a/test/inspector/runtime/console-time-repeat-expected.txt [add] https://crrev.com/3cfbcc725c2423a25b7c6986bdc127d2605c6a0a/test/inspector/runtime/console-time-repeat.js
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/449d25524a82d1d93999ed2dcf5dbb3e2e926080 commit 449d25524a82d1d93999ed2dcf5dbb3e2e926080 Author: Erik Luo <luoe@chromium.org> Date: Mon Dec 04 19:51:53 2017 DevTools: rebase expectations after V8 console time/count changes Relevant V8 CLs have landed in this autoroll: https://chromium-review.googlesource.com/c/chromium/src/+/805157 Bug: 700624 , 727514 Change-Id: I73392015ee47bb79499cc7ee8b447673c00387da Reviewed-on: https://chromium-review.googlesource.com/806258 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521418} [modify] https://crrev.com/449d25524a82d1d93999ed2dcf5dbb3e2e926080/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 4 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by krajshree@chromium.org
, Jun 8 2017Components: Platform>DevTools
Labels: Needs-Feedback
Unable to reproduce the issue in MacBook Pro (Retina, 15-inch, Mid 2014), 10.12.5 and Win-10 using chrome version #59.0.3071.86. Following are the steps followed to reproduce the issue. ------------ 1. Opened the DevTools and navigated to the console 2. Ran console.time("label") in the console. 3. Again ran console.time("label");console.timeEnd("label"). 4. Observed that multiple calls to an existing timer did not reset the timer as expected. Attaching screen cast for reference. domfarolino@ - Could you please verify the screen cast and please let us know if anything missed from our side. Also if possible please provide a screen cast or screen shot of the issue for better triaging. Please mention the OS in which the issue was reported. Thanks...!!420 KB
420 KB View Download