New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727511 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.7%-4.2% regression in memory.top_10_mobile_stress at 474468:474580

Project Member Reported by toyoshim@chromium.org, May 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 30 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_m_intl_taobao_com_group_purchase_html

Revision             Result                   N
chromium@474467      94155532 +- 9869593      21      good
chromium@474577      94177573 +- 5682815      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8978194700143018096

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6349655236935680


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 31 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_m_intl_taobao_com_group_purchase_html
  Change       : 1.75% | 94526577.7778 -> 95157956.9231

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/035b78d057539f9542f9962411108fce5e2085ba..0574bff50ee94cf8fad28f33c2869ea09d39fe82


Revision             Result                   N
chromium@474467      94526578 +- 5514575      9        good
chromium@474522      94084210 +- 3666297      9        good
chromium@474550      94245449 +- 6673401      14       good
chromium@474553      94431915 +- 584586       6        good
chromium@474555      94534997 +- 59191.6      6        good
chromium@474556      ---                      ---      build failure
chromium@474557      94916023 +- 9477505      14       bad
chromium@474566      95398473 +- 4805551      14       bad
chromium@474577      95157957 +- 7216444      13       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8978182098202889664

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6349655236935680


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: sunn...@chromium.org
let me assign sunnyps@ because another candidate, 474556, looks clearly not affecting memory usage.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

Cc: fsam...@chromium.org
Owner: fsam...@chromium.org

=== Auto-CCing suspected CL author fsamuel@chromium.org ===

Hi fsamuel@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : fsamuel
  Commit : b520968f4ac40fb89ce25329134b388ca42cca12
  Date   : Thu May 25 03:10:42 2017
  Subject: cc::SurfaceDependencyTracker should not crash when a Display goes away

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:private_dirty_size_avg/foreground/https_m_facebook_com_rihanna
  Change       : 2.56% | 63585549.3333 -> 65213709.3333

Revision             Result                  N
chromium@474400      63585549 +- 452471      6      good
chromium@474500      63933027 +- 736179      6      good
chromium@474525      63644395 +- 616020      5      good
chromium@474538      63790349 +- 722486      6      good
chromium@474539      64928082 +- 246619      5      bad       <--
chromium@474540      65009592 +- 246288      6      bad
chromium@474541      64913336 +- 460795      5      bad
chromium@474544      65064069 +- 528920      5      bad
chromium@474550      65110627 +- 384432      6      bad
chromium@474600      65213709 +- 415847      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976995979272641408

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6093365847785472


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
Should be back to normal levels ToT after I landed https://codereview.chromium.org/2917743002/

Sign in to add a comment