New issue
Advanced search Search tips

Issue 727488 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

goma failures on Win x64 after clang switch

Project Member Reported by thakis@chromium.org, May 30 2017

Issue description

https://build.chromium.org/p/chromium/builders/Win%20x64/builds/11755
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/11756

The first build had a compile close to 2h, so I thought maybe it's just a timeout. The second build hit this after 1h.

(Also, postprocess_for_goma.upload_log takes 14min to run when goma errors occur, this might be a problem too.)

[48817/51111] CXX obj/chrome/test/unit_tests/security_state_tab_helper_unittest.obj
FAILED: obj/chrome/test/unit_tests/security_state_tab_helper_unittest.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/test/unit_tests/security_state_tab_helper_unittest.obj.rsp /c ../../chrome/browser/ssl/security_state_tab_helper_unittest.cc /Foobj/chrome/test/unit_tests/security_state_tab_helper_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb"
E0529 21:47:37.506515  3416 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc
compiler proxy isn't running. Exiting.
[48818/51111] CXX obj/chrome/test/unit_tests/resource_prefetch_predictor_unittest.obj
FAILED: obj/chrome/test/unit_tests/resource_prefetch_predictor_unittest.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/test/unit_tests/resource_prefetch_predictor_unittest.obj.rsp /c ../../chrome/browser/predictors/resource_prefetch_predictor_unittest.cc /Foobj/chrome/test/unit_tests/resource_prefetch_predictor_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb"
E0529 21:47:37.504515  6684 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc
compiler proxy isn't running. Exiting.
[48819/51111] CXX obj/chrome/test/unit_tests/chrome_signin_client_unittest.obj
FAILED: obj/chrome/test/unit_tests/chrome_signin_client_unittest.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/test/unit_tests/chrome_signin_client_unittest.obj.rsp /c ../../chrome/browser/signin/chrome_signin_client_unittest.cc /Foobj/chrome/test/unit_tests/chrome_signin_client_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb"
E0529 21:47:37.505515  6872 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc
compiler proxy isn't running. Exiting.
[48820/51111] CXX obj/chrome/test/unit_tests/account_reconcilor_unittest.obj
FAILED: obj/chrome/test/unit_tests/account_reconcilor_unittest.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/test/unit_tests/account_reconcilor_unittest.obj.rsp /c ../../chrome/browser/signin/account_reconcilor_unittest.cc /Foobj/chrome/test/unit_tests/account_reconcilor_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb"
E0529 21:47:37.504515   992 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc
compiler proxy isn't running. Exiting.
[48821/51111] CXX obj/chrome/test/unit_tests/download_status_updater_unittest.obj
FAILED: obj/chrome/test/unit_tests/download_status_updater_unittest.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/test/unit_tests/download_status_updater_unittest.obj.rsp /c ../../chrome/browser/download/download_status_updater_unittest.cc /Foobj/chrome/test/unit_tests/download_status_updater_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb"
E0529 21:47:37.504515  6636 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc
compiler proxy isn't running. Exiting.


I will revert the clang switch soon, so this isn't urgent, but we need to fix it before we switch again.
 

Comment 1 by tikuta@chromium.org, May 30 2017

Labels: Restrict-View-Google
Thank you for reporting.

Tracked in https://b.corp.google.com/issues/36493466
Mitigation will be included in next client release.

Comment 2 by ukai@chromium.org, May 30 2017

http://b/36493466
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d553d8e2aaf62876c4f810b973e248d3d31f0d11

commit d553d8e2aaf62876c4f810b973e248d3d31f0d11
Author: thakis <thakis@chromium.org>
Date: Thu Jun 01 00:44:29 2017

win: Explicitly disable symbols on bots using goma.

With MSVC, goma implicitly disables symbols in compiler.gni. With clang,
that isn't the case, so when we enable clang by default, it currently
also implicitly enables debug info on all bots using goma. Explicitly
turn off symbols on these bots. With MSVC, that's no behavior change,
and it makes sure symbols stay off when we enable clang.

BUG= 82385 , 727488 

Review-Url: https://codereview.chromium.org/2914803003
Cr-Commit-Position: refs/heads/master@{#476116}

[modify] https://crrev.com/d553d8e2aaf62876c4f810b973e248d3d31f0d11/tools/mb/mb_config.pyl

Status: Fixed (was: Untriaged)
Here's hoping things are better after comment 3.

Sign in to add a comment