New issue
Advanced search Search tips

Issue 727486 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

We should rename VisibleSlection::end() to End()

Project Member Reported by yosin@chromium.org, May 30 2017

Issue description

Due by grate renaming, the tool kept VisibleSelection::end().
Since |VS::end()| isn't for range, we should rename it to |End()|.

There are 110 references as of May 30, 2017.
 

Comment 1 by yosin@chromium.org, Jun 1 2017

Owner: yosin@chromium.org
Status: Started (was: Available)
In review: http://crrev.com/2920733002
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48496eefc2ca8dc673daf4eff0d45a0822489ebf

commit 48496eefc2ca8dc673daf4eff0d45a0822489ebf
Author: yosin <yosin@chromium.org>
Date: Fri Jun 02 01:08:04 2017

Rename VisibleSelection::end() to End()

This patch renames |VisibleSelection::end()| to |End()| to follow Blink coding
style.

BUG= 727486 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2920733002
Cr-Commit-Position: refs/heads/master@{#476508}

[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/48496eefc2ca8dc673daf4eff0d45a0822489ebf/third_party/WebKit/Source/web/WebViewImpl.cpp

Comment 3 by yosin@chromium.org, Jun 2 2017

Status: Fixed (was: Started)

Sign in to add a comment