New issue
Advanced search Search tips

Issue 727463 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

webkit_tests failing on WebKit Win10, WebKit Win7 after clang switch

Project Member Reported by thakis@chromium.org, May 30 2017

Issue description

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/52842
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/22536

Total tests: 68186
* Passed: 56833 (56701 expected, 132 unexpected)
* Skipped: 9279 (9279 expected, 0 unexpected)
* Failed: 1929 (1640 expected, >>>289 unexpected<<<)
* Flaky: 145 (145 expected, 0 unexpected)

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/22536/layout-test-results/results.html

/

Total tests: 68186
* Passed: 56846 (56724 expected, 122 unexpected)
* Skipped: 9266 (9266 expected, 0 unexpected)
* Failed: 1927 (1637 expected, >>>290 unexpected<<<)
* Flaky: 147 (147 expected, 0 unexpected)

(win7 results link once it's done uploading)


I looked through a few of the pixel diffs, most of them look harmless and are probably due to things like float rounding and whatnot. I'd expect that we don't have to do anything here except rebase a bunch of stuff when we land for real (or for longer than a few hours).
 
Screen Shot 2017-05-29 at 11.42.37 PM.png
906 KB View Download
Screen Shot 2017-05-29 at 11.41.36 PM.png
696 KB View Download
Screen Shot 2017-05-29 at 11.41.09 PM.png
507 KB View Download
Screen Shot 2017-05-29 at 11.40.45 PM.png
448 KB View Download

Comment 1 by thakis@chromium.org, May 30 2017

win7 results: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/52842/layout-test-results/results.html (the handful of diffs I looked at look similarly boring)
Screen Shot 2017-05-29 at 11.53.32 PM.png
431 KB View Download

Comment 2 by h...@chromium.org, Jun 1 2017

Looking at the rebaselines as part of https://codereview.chromium.org/2916933002/, it seems many (but not all) tests now line up across linux/mac/win.

For example, in the rebaseline animations/skew-notsequential-compositor-expected.png moves from having expectations in  platform/{linux,mac,win} to just having one expectation file for all platforms.

This seems like another nice benefit of using the same compiler everywhere.

Comment 3 Deleted

Comment 4 by thakis@chromium.org, Jul 31 2017

Owner: h...@chromium.org
Status: Fixed (was: Untriaged)
We rebased those when we switched.

Sign in to add a comment