New issue
Advanced search Search tips

Issue 727459 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
yyushkina@chromium.org
napper@chromium.org
anthonyvd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Improve coverage of translation unit tests

Project Member Reported by napper@chromium.org, May 30 2017 
There are many missing unit tests in the Chrome translate code. We should add unit tests to improve code quality and the detection of regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8415c5b1c8cdbcec5c3e6f8e99dfd1f1f2404601

commit 8415c5b1c8cdbcec5c3e6f8e99dfd1f1f2404601
Author: Jon Napper <napper@chromium.org>
Date: Thu Jun 22 01:11:01 2017

Added unit tests for translate_experiment.cc.

Added unit tests for translate_experiment.cc.

Bug: 727459
Change-Id: I849f0a2d4bb6b074a92dafd340de2a089eb4ba18
Reviewed-on: https://chromium-review.googlesource.com/542575
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Jon Napper <napper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481387}
[modify] https://crrev.com/8415c5b1c8cdbcec5c3e6f8e99dfd1f1f2404601/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/8415c5b1c8cdbcec5c3e6f8e99dfd1f1f2404601/components/translate/core/browser/translate_experiment.h
[add] https://crrev.com/8415c5b1c8cdbcec5c3e6f8e99dfd1f1f2404601/components/translate/core/browser/translate_experiment_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4f544c2d4e9477973cf8ad227dee0c796e43e00

commit a4f544c2d4e9477973cf8ad227dee0c796e43e00
Author: Jon Napper <napper@chromium.org>
Date: Mon Jul 03 03:31:54 2017

Added missing unit tests for translate_language_list.cc

Added missing unit tests for translate_language_list.cc

Bug: 727459
Change-Id: Ie59f5a8e9218f0f3b98be87f9575ec548ae877d6
Reviewed-on: https://chromium-review.googlesource.com/554570
Commit-Queue: Jon Napper <napper@chromium.org>
Reviewed-by: Patricia Lor <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483932}
[modify] https://crrev.com/a4f544c2d4e9477973cf8ad227dee0c796e43e00/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/a4f544c2d4e9477973cf8ad227dee0c796e43e00/components/translate/core/browser/translate_language_list.h
[modify] https://crrev.com/a4f544c2d4e9477973cf8ad227dee0c796e43e00/components/translate/core/browser/translate_language_list_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79ffdf2fb7fd4f436a1e7452c3a937df1a2d8af

commit e79ffdf2fb7fd4f436a1e7452c3a937df1a2d8af
Author: Jon Napper <napper@chromium.org>
Date: Tue Jul 11 03:07:01 2017

Added missing unit test for translate_service.cc

Added missing unit test for translate_service.cc

Bug: 727459
Change-Id: Iae3cdded7bb934fd59a7248cf342bce85c44ee69
Reviewed-on: https://chromium-review.googlesource.com/564871
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Jon Napper <napper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485507}
[modify] https://crrev.com/e79ffdf2fb7fd4f436a1e7452c3a937df1a2d8af/chrome/browser/translate/translate_service_unittest.cc

Comment 4 by napper@chromium.org, Feb 5 2018

Owner: ----

Comment 5 by yyushkina@chromium.org, Mar 7 2018

Cc: yyushkina@chromium.org anthonyvd@chromium.org napper@chromium.org
Status: Available (was: Assigned)
Hey Jon - are there more missing tests or should this be marked as fixed?
►

Sign in to add a comment