New issue
Advanced search Search tips

Issue 727458 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

PrerenderBrowserTest.PrerenderRendererCrash, DevToolsReattachAfterCrashTest.TestReattachAfterCrashOnTimeline failing on Win7 Tests (dbg)(1) after clang switch

Project Member Reported by thakis@chromium.org, May 30 2017

Issue description

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60403

[ RUN      ] PrerenderBrowserTest.PrerenderRendererCrash
[1548:4868:0529/195136.219:WARNING:chrome_browser_main_win.cc(466)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --gtest_also_run_disabled_tests --gtest_filter=PrerenderBrowserTest.PrerenderRendererCrash --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\iox3_jhz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1976_493\d1976_11737" --disable-offline-auto-reload --enable-pepper-testing --register-pepper-plugins="e:\b\swarm_slave\w\ir\out\Debug\power_saver_test_plugin.dll#Shockwave Flash#Description#100.0;application/x-shockwave-flash" --disable-features=NetworkPrediction --no-first-run --no-default-browser-check --enable-logging=stderr --log-level=0 --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --enable-features=PreferHtmlOverPlugins --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[1548:4868:0529/195136.714:INFO:easy_unlock_service_regular.cc(446)] Initializing EasyUnlockService inside the user session.
[576:3988:0529/195136.782:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
[1548:4040:0529/195138.249:ERROR:test_database_manager.cc(58)] NOT IMPLEMENTED
[1548:2640:0529/195138.449:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[4128:4236:0529/195139.707:ERROR:render_frame_impl.cc(864)] Intentionally crashing (with null pointer dereference) because user navigated to chrome://crash/


Not very informative. Likely due to the clang switch.

Not sure about the ync_integration_tests though – some of them also failed on the prior few runs, and the failure message looks identical in all tests I looked at (and identical to the failure message in prior runs).
 

Comment 1 by thakis@chromium.org, May 30 2017

Labels: -OS-Mac
*sync_integration_tests
PrerenderBrowserTest.PrerenderRendererCrash is a new failure.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PrerenderRendererCrash

DevToolsReattachAfterCrashTest.TestReattachAfterCrashOnTimeline is also a new failure.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TestReattachAfterCrashOnTimeline

Ah, yeah, likely to due the clang switch. The flakiness dashboard data is just for checking.

Comment 4 by thakis@chromium.org, May 30 2017

After the revert, most sync_integration_tests started passing again but one didn't: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60407

In https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60409 with https://chromium-review.googlesource.com/517494 that test stopped failing too. Still not sure if sync_integration_tests is related to the switch, but the two browser tests very likely are.

Comment 5 by h...@chromium.org, Jul 31 2017

Owner: h...@chromium.org
Status: Assigned (was: Untriaged)
I can't repro the browser_tests failures locally. Let's try turning them back on: https://chromium-review.googlesource.com/595189
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa392a031534cf201903b21b9951f3626f3f535b

commit aa392a031534cf201903b21b9951f3626f3f535b
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Aug 01 06:03:31 2017

Re-enable two browser tests after the win/clang switch

These failed during the first win/clang experiment in May (see bug),
so were preemptively disabled when we switched to clang. However,
they pass for me locally, so it's possible the regression no longer
exists.

BUG= 727458 

Change-Id: I11253e185f66f48050187eee29cbc871c2f48d80
Reviewed-on: https://chromium-review.googlesource.com/595189
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490872}
[modify] https://crrev.com/aa392a031534cf201903b21b9951f3626f3f535b/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/aa392a031534cf201903b21b9951f3626f3f535b/chrome/browser/prerender/prerender_browsertest.cc

Comment 7 by h...@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)
The bot is green: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/

Sign in to add a comment