New issue
Advanced search Search tips

Issue 727443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"BlobMemoryControllerTest.OnMemoryPressure" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 30 2017

Issue description

"BlobMemoryControllerTest.OnMemoryPressure" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilCbG9iTWVtb3J5Q29udHJvbGxlclRlc3QuT25NZW1vcnlQcmVzc3VyZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: dmu...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to one of storage/browser/blob/OWNERS
This is reporting flakiness on "with patch" step, but maybe the system detected 3 failures in sequence with different patches (thank you yhirano@ for helping investigation).

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=storage_unittests&tests=BlobMemoryControllerTest.OnMemoryPressure
"without patch" step has some failures happened a few days ago recorded.

Once it occurs again, maybe we should disable it.

Labels: -Sheriff-Chromium

Comment 4 by dmu...@chromium.org, May 30 2017

Hm. I'm not sure why this is flaky. Will investigate.

Comment 5 by dmu...@chromium.org, May 30 2017

Cc: dmu...@chromium.org
Owner: ssid@chromium.org
@ssid I'm a little swamped. Since you authored this part of the code, do you mind taking a quick look at why it might be flaky?
Labels: Sheriff-Chromium
Labels: -Sheriff-Chromium
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, May 31 2017

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "BlobMemoryControllerTest.OnMemoryPressure". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilCbG9iTWVtb3J5Q29udHJvbGxlclRlc3QuT25NZW1vcnlQcmVzc3VyZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 by ssid@chromium.org, May 31 2017

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95db2e01abad611ea87edae5a036e109a6085328

commit 95db2e01abad611ea87edae5a036e109a6085328
Author: ssid <ssid@chromium.org>
Date: Wed May 31 21:55:48 2017

Fix BlobMemoryControllerTest.OnMemoryPressure

If TimeTicks::Now returns number close to 30 seconds on the first
call then test would fail. So, check if last_eviction_time_ is 0.

BUG= 727443 

Review-Url: https://codereview.chromium.org/2918523003
Cr-Commit-Position: refs/heads/master@{#476050}

[modify] https://crrev.com/95db2e01abad611ea87edae5a036e109a6085328/storage/browser/blob/blob_memory_controller.cc

Comment 13 by ssid@chromium.org, Jul 17 2017

Status: Fixed (was: Started)
No flake in last one month.

Sign in to add a comment