win GPU FYI bots fail to build with clang-cl |
||||||||||||||||||||||||||
Issue descriptionI flipped on is_clang=true by default on Windows today (May 29 – I'll revert it again in a bit). The GPU/FYI Win bots went red: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder/builds/69681 https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20x64%20Builder/builds/26819 Failures: FAILED: obj/third_party/angle/src/tests/angle_deqp_decpp/deMemPool.obj E:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_decpp/deMemPool.obj.rsp /c ../../third_party/deqp/src/framework/delibs/decpp/deMemPool.cpp /Foobj/third_party/angle/src/tests/angle_deqp_decpp/deMemPool.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_decpp_cc.pdb" In file included from <built-in>:353: <command line>(39,9): error: '_HAS_EXCEPTIONS' macro redefined [-Werror,-Wmacro-redefined] #define _HAS_EXCEPTIONS 1 ^ <command line>(15,9): note: previous definition is here #define _HAS_EXCEPTIONS 0 ^ 1 error generated. There are possibly more errors hidden by these errors. The fix for this is to not rely on -D flips overriding each other but using gn's configs to make sure only one of these two flags are present. We either need to fix this before flipping on clang by default on Windows, or explicitly toggle off clang on the GPU fyi bots (and have them not use the then-default windows config).
,
May 30 2017
,
May 30 2017
I've had an in-progress CL for a long time to fix this, https://codereview.chromium.org/2214743002/ .. Nico would you like to take on finishing this? Otherwise you can send it to me.
,
May 30 2017
Have at it! :-)
,
May 30 2017
K. If you need to tackle this at a higher than Pri-3 than I suggest you take over.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f307f2f73c304ee22ac9fb43d3ce4fbf493ae4a commit 4f307f2f73c304ee22ac9fb43d3ce4fbf493ae4a Author: thakis <thakis@chromium.org> Date: Wed May 31 21:52:20 2017 Force off clang for GPU FYI release bots. The GPU FYI release bots went red when we switched on clang by default. It doesn't sound like that'll be fixed soon, so let's explicitly disable clang on these FYI bots so that they're not affected the next time we turn it on by default. BUG= 727437 Review-Url: https://codereview.chromium.org/2920573002 Cr-Commit-Position: refs/heads/master@{#476048} [modify] https://crrev.com/4f307f2f73c304ee22ac9fb43d3ce4fbf493ae4a/tools/mb/mb_config.pyl
,
Jul 20 2017
,
Jul 31 2017
Removing blocker; bots were happy when we switched chromium/win to clang for real. We'll stop supporting msvc for chromium eventually, so if gpu.fyi builds any chromium code you might want to consider addressing this before that stops working.
,
Aug 1 2017
We need to deploy new Win builders and testers for the dEQP tests. Unfortunately we'll have to lose coverage on the non-Swarmed configurations, since we are going to need a separate test machine to trigger just the dEQP tests which will be built with msvc, in addition to the builder. Jamie: I think these are the four configurations which we can support running the dEQP tests on in this new mode. We will need one Windows VM for each: https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/ https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win7%20Release%20%28AMD%29/ https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win7%20Release%20%28NVIDIA%29/ https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win7%20x64%20Release%20%28NVIDIA%29/ Does that sound correct? Are the Win10/Win7 NVIDIA configs redundant when it comes to the dEQP tests? If so, let's just test Win10. We need 2 more VMs in addition to these, which will be for the 32-bit and 64-bit builders that trigger tests on these configs. Could you please file a Labs ticket requesting these VMs? Thanks.
,
Aug 1 2017
Ken, this is a bit absurd. Don't we just want to fix the no exceptions config? Sorry if I'm missing something.
,
Aug 1 2017
I don't follow. We need to build the dEQP tests with a totally different configuration (and, now, toolchain) than all of the other targets. To do this we need different builders than the other bots, which build Chromium-related targets.
,
Aug 1 2017
Sorry, I dug around in the email chain and got clarity. I was wondering why we wouldn't just want to make a three line change to fix the build instead of doing the work to split off an unsupported toolchain. Regarding exceptions Nico said of these tools: "They support it, but it causes ongoing maintenance costs. Each time we tweak build settings, we have to think about exceptions cause that one library used on that one set of fyi boys doesn't conform to the style guide."
,
Aug 1 2017
,
Aug 2 2017
You can fix the bot config as a short-term thing. Long term, I don't want us (chrome compiler / build people) on the hook for the maintenance cost of a project that chooses to ignore the google style guide.
,
Aug 2 2017
Ken, it looks like no matter what we do, we will need exceptions with Clang on Linux and Mac. The option of disabling dEQP is not really feasible, we depend on them quite a bit now. I'm going to be on vacation now so I'll pass this issue over to you.
,
Aug 2 2017
,
Aug 7 2017
Possibly relevant forward-looking information: dEQP is the framework for the Khronos conformance tests for ES & Vulkan at this point, so conformance testing for any of those APIs is going to rely on it, whether or not ANGLE does. (If we're still running the ES CTS, this will come in if we ever update it, and will presumably block us from moving it off of FYI even though the tests have become open-source.)
,
Aug 12 2017
Nico and I talked in real time. In sum, there are two basic options when building this test suite: 1) Use the system compiler 2) Still use Clang, but a pinned version To be sure: the expectation is that upstream Clang will continue to support exceptions and RTTI. The main concern from Chrome's build team is that as they roll forward Clang, they don't want breakage of this test suite on the FYI waterfalls to cause Clang to be rolled back. They're happy to work with us to fix the failures within, for example, a 1-2 week timeframe. (Obviously, these bots could not stay red that entire time.) (2) is a much better option than (1). It will keep these bots on the same compiler train as the rest of Chromium, and allow them to choose when to roll forward -- when Clang is in a known good state with respect to this suite. I'm pursuing this approach. A couple of other projects already pin buildtools (PDFium and Chrome for iOS), but the mechanisms used are different -- PDFium pins buildtools in their standalone checkout. Since these bots will still run the Chromium recipe, we'll need to possibly pin them in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/gclient_config.py (where the angle_top_of_tree configuration is defined), or maybe in a different way. Putting the hardware on the waterfall now. We'll adjust the builders' configurations afterward.
,
Aug 12 2017
Talking with dpranke@, far and away the best way to maintain the (possibly) separate buildtools version for the dEQP tests would be a conditional in src/DEPS. That would allow tryjobs to be sent through testing rolls forward of buildtools used for dEQP. Blocking this bug on that work -- Issue 570091 -- because it's a strong motivator for pushing it over the finish line.
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/549126787d2495bef4bc0e6171850b2692dda457 commit 549126787d2495bef4bc0e6171850b2692dda457 Author: Kenneth Russell <kbr@chromium.org> Date: Sat Aug 12 01:54:42 2017 Deploy builders/testers specialized for dEQP tests. These bots are going to use a pinned version of Clang that can roll forward separately, in order to insulate themselves from changes to Chromium's toolchain. This test suite uses language features (exceptions, RTTI) which aren't used by the rest of Chromium, and it's necessary to allow Clang to roll forward even if a bug impacts this test suite, in particular to allow emergency fixes to roll into Chromium. BUG= 727437 Change-Id: I94621b8d8dfec0e466d5d5b02e7d01aca9a89ff2 Reviewed-on: https://chromium-review.googlesource.com/612626 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/549126787d2495bef4bc0e6171850b2692dda457/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py [modify] https://crrev.com/549126787d2495bef4bc0e6171850b2692dda457/masters/master.chromium.gpu.fyi/builders.pyl
,
Aug 13 2017
,
Aug 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/110c7d79041c7d35fa5f1b90c53eb9c865635ee9 commit 110c7d79041c7d35fa5f1b90c53eb9c865635ee9 Author: Kenneth Russell <kbr@google.com> Date: Tue Aug 15 02:42:04 2017
,
Aug 15 2017
,
Aug 16 2017
,
Aug 17 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/159aad62592b5cb0f7d43de75355eb4465587510 commit 159aad62592b5cb0f7d43de75355eb4465587510 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 18 01:39:32 2017 Deploy desktop dEQP builders and testers. These will use a different build configuration than the other builders and testers; namely, enabling exceptions and RTTI. Initially, just cloning the configuration and getting the tests running on these bots. BUG= 727437 TBR=dpranke@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3e83b1a8445433174b90c7d3083477485934d1af Reviewed-on: https://chromium-review.googlesource.com/619569 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#495416} [modify] https://crrev.com/159aad62592b5cb0f7d43de75355eb4465587510/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/159aad62592b5cb0f7d43de75355eb4465587510/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/159aad62592b5cb0f7d43de75355eb4465587510/tools/mb/mb_config.pyl
,
Aug 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25eabb26b0bc74fe1703f05717c2c7b762144e0c commit 25eabb26b0bc74fe1703f05717c2c7b762144e0c Author: Kenneth Russell <kbr@chromium.org> Date: Sat Aug 19 00:15:26 2017 Fix predicates for dEQP bots. They were causing essentially all of the tests to run on the dEQP-specific bots. BUG= 727437 TBR=jmadill@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I813c6d64b41f797847fded4529c50cd5b433108c Reviewed-on: https://chromium-review.googlesource.com/621817 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#495759} [modify] https://crrev.com/25eabb26b0bc74fe1703f05717c2c7b762144e0c/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/25eabb26b0bc74fe1703f05717c2c7b762144e0c/testing/buildbot/chromium.gpu.fyi.json
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da59a2985a3dfcfcade15f87d50951812bafb5d1 commit da59a2985a3dfcfcade15f87d50951812bafb5d1 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Aug 22 18:27:46 2017 Fix GPU dEQP bots configuration This fixes two problems: - A Mac dEQP bot was added but no tests were added to it, causing the bot to pick up tasks for other Mac bots (why?) - GPU Win x64 dEQP Builder didn't have a config defined in mb_comfig.pyl BUG= chromium:727437 TBR=phajdan.jr@chromium.org TBR=zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I05e30dce90ad5e093bd5bf7fdf6335853c1a4b25 Reviewed-on: https://chromium-review.googlesource.com/623913 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#496375} [modify] https://crrev.com/da59a2985a3dfcfcade15f87d50951812bafb5d1/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/da59a2985a3dfcfcade15f87d50951812bafb5d1/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/da59a2985a3dfcfcade15f87d50951812bafb5d1/tools/mb/mb_config.pyl
,
Aug 24 2017
,
Aug 24 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/6ecf9d176f79abb42177331a3f2e4f3fade04811 commit 6ecf9d176f79abb42177331a3f2e4f3fade04811 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Aug 24 20:27:58 2017 Deploy Win and Linux dEQP tryservers on tryserver.chromium.angle. win_angle_deqp_rel_ng triggers jobs on NVIDIA and AMD GPUs. win_angle_x64_deqp_rel_ng and linux_angle_deqp_rel_ng trigger jobs on NVIDIA GPUs. BUG= 727437 TBR=dpranke@chromium.org Change-Id: I5c5be4fc56d0bbb80ee8c4afe4f94ff8ce5c5976 Reviewed-on: https://chromium-review.googlesource.com/633827 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/6ecf9d176f79abb42177331a3f2e4f3fade04811/masters/master.tryserver.chromium.angle/slaves.cfg [modify] https://crrev.com/6ecf9d176f79abb42177331a3f2e4f3fade04811/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/6ecf9d176f79abb42177331a3f2e4f3fade04811/masters/master.tryserver.chromium.angle/master.cfg
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bf5b92bbf166e91b6d84fd5c8fcecb195fe50667 commit bf5b92bbf166e91b6d84fd5c8fcecb195fe50667 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Aug 24 21:55:11 2017 Deploy Android dEQP builder/tester on chromium.gpu.fyi. This bot will only trigger tests in the swarmed Nexus 5X pool. It might eventually need to use a different compiler configuration than the regular Android bots since the dEQP test suite uses exceptions and RTTI. BUG= 727437 TBR=dpranke@chromium.org Change-Id: I852d81eb6f366435a9cc53ce1eebe109098c1c56 Reviewed-on: https://chromium-review.googlesource.com/634324 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/bf5b92bbf166e91b6d84fd5c8fcecb195fe50667/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py [modify] https://crrev.com/bf5b92bbf166e91b6d84fd5c8fcecb195fe50667/masters/master.chromium.gpu.fyi/builders.pyl
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10399ab4abeade88b15a928da249065c3e9218d commit e10399ab4abeade88b15a928da249065c3e9218d Author: Kenneth Russell <kbr@chromium.org> Date: Thu Aug 24 23:23:37 2017 Add mb_config.pyl entries for new ANGLE dEQP tryservers. BUG= 727437 TBR=dpranke@chromium.org Change-Id: I1c27a3eee93b816154781a7ffc2f4ecf31066730 Reviewed-on: https://chromium-review.googlesource.com/633848 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#497245} [modify] https://crrev.com/e10399ab4abeade88b15a928da249065c3e9218d/tools/mb/mb_config.pyl
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd67dc6f66f9a10a9f4a02b7f92886038394c054 commit dd67dc6f66f9a10a9f4a02b7f92886038394c054 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 25 02:46:53 2017 Run tests on "Android dEQP Release (Nexus 5X)". BUG= 727437 TBR=ynovikov@chromium.org, dpranke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I525adf3379fdd9a1f1f469915b32b8cfc19ff1f7 Reviewed-on: https://chromium-review.googlesource.com/634522 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#497306} [modify] https://crrev.com/dd67dc6f66f9a10a9f4a02b7f92886038394c054/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/dd67dc6f66f9a10a9f4a02b7f92886038394c054/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/dd67dc6f66f9a10a9f4a02b7f92886038394c054/tools/mb/mb_config.pyl
,
Aug 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/c2055a7555d75df98d19d61b298580ffaccbde60 commit c2055a7555d75df98d19d61b298580ffaccbde60 Author: Kenneth Russell <kbr@google.com> Date: Fri Aug 25 15:10:23 2017
,
Aug 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/a7b24d0d4ab64d8befa1450217ed302f3ec9ecc9 commit a7b24d0d4ab64d8befa1450217ed302f3ec9ecc9 Author: Kenneth Russell <kbr@google.com> Date: Fri Aug 25 15:10:53 2017
,
Aug 25 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/90341f84e25d43b32c567e9aa91bf8aad8156fdd commit 90341f84e25d43b32c567e9aa91bf8aad8156fdd Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 25 22:15:53 2017 Deploy android_angle_deqp_rel_ng on tryserver.chromium.angle. Like the desktop dEQP trybots, this will be responsible for running just the dEQP tests. BUG= 727437 TBR=dpranke@chromium.org Change-Id: I3ac9a0c7ee6a1bc1761721159bbd35faae97d8e2 Reviewed-on: https://chromium-review.googlesource.com/636454 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/90341f84e25d43b32c567e9aa91bf8aad8156fdd/masters/master.tryserver.chromium.angle/slaves.cfg [modify] https://crrev.com/90341f84e25d43b32c567e9aa91bf8aad8156fdd/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/90341f84e25d43b32c567e9aa91bf8aad8156fdd/masters/master.tryserver.chromium.angle/master.cfg
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d3feb3c8a67577b1a7d6566febddd5ef38afb5e commit 3d3feb3c8a67577b1a7d6566febddd5ef38afb5e Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 25 23:16:52 2017 Add mb_config.pyl entry for android_angle_deqp_rel_ng. BUG= 727437 TBR=dpranke@chromium.org Change-Id: Ifd0146c9ff3cca32fcb0bb6634c7bb8c19e3494c Reviewed-on: https://chromium-review.googlesource.com/636217 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#497588} [modify] https://crrev.com/3d3feb3c8a67577b1a7d6566febddd5ef38afb5e/tools/mb/mb_config.pyl
,
Aug 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/516cedc7180c4ebdeefdfee00b59de5f2cd6e72a commit 516cedc7180c4ebdeefdfee00b59de5f2cd6e72a Author: Kenneth Russell <kbr@google.com> Date: Sat Aug 26 17:01:01 2017
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/ef66151703318c4c5c975c01e8d1b1efbaf97b0b commit ef66151703318c4c5c975c01e8d1b1efbaf97b0b Author: Kenneth Russell <kbr@chromium.org> Date: Sat Aug 26 18:47:11 2017 Add ANGLE dEQP trybots to default set of tryservers. These trybots -- for Win, Linux, and Android -- are all working now per https://chromium-review.googlesource.com/636294 . Make them run for all ANGLE CLs so that the dEQP tests can be removed from the others. This will allow the dEQP bots' compiler configuration to ultimately diverge from the other bots'. BUG= 727437 TBR=geofflang@chromium.org Change-Id: I90ffcd358dfa888b77ecf718727d809c486170c7 Reviewed-on: https://chromium-review.googlesource.com/636759 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/ef66151703318c4c5c975c01e8d1b1efbaf97b0b/infra/config/cq.cfg
,
Aug 26 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/cd25f63484badeac976b91506ce67a7dbd3c904c commit cd25f63484badeac976b91506ce67a7dbd3c904c Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Sat Aug 26 19:54:42 2017 Roll skia/third_party/externals/angle2/ 511937d9a..ef6615170 (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/511937d9a3c7..ef6615170331 $ git log 511937d9a..ef6615170 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep skia/third_party/externals/angle2 BUG= 727437 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=jcgregorio@google.com Change-Id: Icfcd3b8a31bd357ba64c7b8023ac46de908b918a Reviewed-on: https://skia-review.googlesource.com/39080 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/cd25f63484badeac976b91506ce67a7dbd3c904c/DEPS
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c0407bf83980abfbe01e8577b066202bae8f83a commit 6c0407bf83980abfbe01e8577b066202bae8f83a Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Sat Aug 26 22:19:06 2017 Roll src/third_party/skia/ 445b55736..cd25f6348 (1 commit) https://skia.googlesource.com/skia.git/+log/445b55736131..cd25f63484ba $ git log 445b55736..cd25f6348 --date=short --no-merges --format='%ad %ae %s' 2017-08-26 angle-deps-roller Roll skia/third_party/externals/angle2/ 511937d9a..ef6615170 (1 commit) Created with: roll-dep src/third_party/skia BUG= 727437 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I96b79e63f1218e6158299db27714d6249e784127 Reviewed-on: https://chromium-review.googlesource.com/636711 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#497666} [modify] https://crrev.com/6c0407bf83980abfbe01e8577b066202bae8f83a/DEPS
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76003da7790d98dae08cce4a9be690f741e28b47 commit 76003da7790d98dae08cce4a9be690f741e28b47 Author: Kenneth Russell <kbr@chromium.org> Date: Sat Aug 26 23:21:45 2017 Roll ANGLE 2c1183b..ef66151 https://chromium.googlesource.com/angle/angle.git/+log/2c1183b..ef66151 BUG= 727437 TEST=bots TBR=geofflang@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7d5071f32783072f3cde9ad698362f3e19fc514f Reviewed-on: https://chromium-review.googlesource.com/636055 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#497668} [modify] https://crrev.com/76003da7790d98dae08cce4a9be690f741e28b47/DEPS
,
Aug 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/094666f0ac3fd9e846b7ce547bf54f5aeafcc59c commit 094666f0ac3fd9e846b7ce547bf54f5aeafcc59c Author: Kenneth Russell <kbr@chromium.org> Date: Sun Aug 27 17:34:07 2017 Completely split off dEQP bots' configurations. Stop running the dEQP tests on non-dEQP bots. This provides the ability to use a completely different compiler configuration on the dEQP bots. Continue to use no_clang on the Win dEQP bots. Still waiting for a fix to Issue 756686 to be able to pin Clang and compiler options on the dEQP bots. BUG= 727437 TBR=jmadill@chromium.org, dpranke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fe3c54db7a13d418d8417b345157b0d805a1137 Reviewed-on: https://chromium-review.googlesource.com/637127 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#497678} [modify] https://crrev.com/094666f0ac3fd9e846b7ce547bf54f5aeafcc59c/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/094666f0ac3fd9e846b7ce547bf54f5aeafcc59c/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/094666f0ac3fd9e846b7ce547bf54f5aeafcc59c/tools/mb/mb_config.pyl
,
Aug 27 2017
All the work that can be done at this point is complete. Waiting for a fix for Issue 756686 in order to be able to pin Clang and the compiler options on the dEQP bots, so they can be switched to the pinned version of Clang and this bug closed.
,
Aug 27 2017
,
Aug 29 2017
FYI Ken your changes to split off the dEQP bots have the side-effect of making the maximum log length a lot smaller for ANGLE CLs. Failing tests on Windows no longer trigger the out of memory exception when parsing logs (issue 713196).
,
Aug 29 2017
OK, that's cool. Do you want to make any changes necessary to make the tests from https://bugs.chromium.org/p/chromium/issues/detail?id=713196#c36 run on Win/AMD again? Or are they already running as an accidental side-effect of the changes above?
,
Sep 12 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f45957366026d96f5d5d2e2137b65058978d2b2 commit 2f45957366026d96f5d5d2e2137b65058978d2b2 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Sep 13 01:14:41 2017 ANGLE: Re-enable dEQP GLES3 tests on AMD. Now that we have enough CQ capacity, put the bots back in operation. BUG=713196, 727437 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I797460bac0313027f2f01031f1a49d223d4887df Reviewed-on: https://chromium-review.googlesource.com/663533 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#501497} [modify] https://crrev.com/2f45957366026d96f5d5d2e2137b65058978d2b2/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/2f45957366026d96f5d5d2e2137b65058978d2b2/testing/buildbot/chromium.gpu.fyi.json
,
Sep 16 2017
,
Nov 13 2017
Going to fix up the Windows dEQP Clang build.
,
Nov 14 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8908aaf8400cf748fa59b515694ee893d8289d6 commit c8908aaf8400cf748fa59b515694ee893d8289d6 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 15 01:01:21 2017 Add temporary config for ANGLE build transition. This will enable switching the configs to enable a cross platform "no exceptions" config and the dEQP build on Windows with Clang. Bug: 727437 Change-Id: I5c241ff88826dfea27c8e9cc7ffefb99ba3e9fb5 Reviewed-on: https://chromium-review.googlesource.com/767628 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#516534} [add] https://crrev.com/c8908aaf8400cf748fa59b515694ee893d8289d6/build/config/angle_temp.gni
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/4d1469315c99e81a8dbda5a226883dddf3cec4b1 commit 4d1469315c99e81a8dbda5a226883dddf3cec4b1 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 15 23:55:58 2017 Roll all ANGLE internal DEPS. None of these deps are used in the Chromium builds, so this only affects the standalone version. Includes a change in the build repo necessary to enable fixing the Clang build with dEQP. Bug: chromium:727437 Change-Id: Iea5f6299e9f17555891c812229a54a850776f117 Reviewed-on: https://chromium-review.googlesource.com/773020 Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/4d1469315c99e81a8dbda5a226883dddf3cec4b1/DEPS
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/39644feebaf4a305b0d93f3f9af86bdc0ac9cee3 commit 39644feebaf4a305b0d93f3f9af86bdc0ac9cee3 Author: Jamie Madill <jmadill@chromium.org> Date: Thu Nov 16 01:09:02 2017 Fix Clang build with dEQP. This will require a Chrome-side patch to the build/ folder to enable the new path, with appropriate Chrome-side changes. Bug: chromium:727437 Change-Id: Iae8d8f4caeead703b322abce75c97c7c9d9e1619 Reviewed-on: https://chromium-review.googlesource.com/773021 Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/39644feebaf4a305b0d93f3f9af86bdc0ac9cee3/src/tests/BUILD.gn
,
Nov 16 2017
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/461b345a815c1c745ac0534a6a4bd52d123abe68 commit 461b345a815c1c745ac0534a6a4bd52d123abe68 Author: Jamie Madill <jmadill@chromium.org> Date: Fri Nov 17 17:55:04 2017 Add migration code for no_exceptions configs. The libc++ configs all enable exceptions to build. This change adds code so that the build works with both the old and new configs. Once http://crrev.com/c/773079 lands then we can go back and fix up the code to use only the new 'compiler:no_exceptions' config. Bug: 727437 Change-Id: If2fe0a74fb3fb27f65d4bd34cb5c1efa64d0e7ee [modify] https://crrev.com/461b345a815c1c745ac0534a6a4bd52d123abe68/third_party/libunwind/BUILD.gn [modify] https://crrev.com/461b345a815c1c745ac0534a6a4bd52d123abe68/third_party/libc++/BUILD.gn [modify] https://crrev.com/461b345a815c1c745ac0534a6a4bd52d123abe68/third_party/libc++abi/BUILD.gn
,
Nov 17 2017
,
Nov 17 2017
Moved Ken's remaining work to ping the Clang version and options to the dEQP bots in issue 786460, unblocking this from 756686, so I can close this out once ANGLE's Clang/Win build is fixed.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d7de5fe800da373521a884e2767c68b5b60cc21 commit 9d7de5fe800da373521a884e2767c68b5b60cc21 Author: Jamie Madill <jmadill@chromium.org> Date: Fri Nov 17 19:51:53 2017 Roll src/buildtools/ 9c40f80c9..461b345a8 (3 commits) https://chromium.googlesource.com/chromium/buildtools.git/+log/9c40f80c9998..461b345a815c $ git log 9c40f80c9..461b345a8 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 jmadill Add migration code for no_exceptions configs. 2017-11-16 thomasanderson Fix typo: fuschia -> fuchsia 2017-11-16 thomasanderson Always hide libunwind symbols on desktop Linux Created with: roll-dep src/buildtools TBR=brettw@chromium.org BUG= 727437 Change-Id: I6dd70fd5ae642dd6a861e02913469f65e333bd19 Reviewed-on: https://chromium-review.googlesource.com/777031 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517520} [modify] https://crrev.com/9d7de5fe800da373521a884e2767c68b5b60cc21/DEPS
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9f5ee0fd4004ab992bdc9413b96680c207e577b commit c9f5ee0fd4004ab992bdc9413b96680c207e577b Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 21 01:24:31 2017 Add configs to control exceptions in GN. This gives the ability for projects to enable or disable exceptions in general manner. Previously this was limited to a GCC/Clang config. This will allow ANGLE to build the dEQP tests with Clang, since they require a specific config to enable exceptions. This only affects Windows builds; other platforms were working correctly. Bug: 727437 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I25f617e4046a868a10b15df56fceec872fb036dc Reviewed-on: https://chromium-review.googlesource.com/773079 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#518019} [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/build/config/BUILDCONFIG.gn [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/build/config/angle_temp.gni [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/build/config/compiler/BUILD.gn [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/build/config/gcc/BUILD.gn [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/build/config/win/BUILD.gn [modify] https://crrev.com/c9f5ee0fd4004ab992bdc9413b96680c207e577b/gpu/khronos_glcts_support/BUILD.gn
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/4f407ce208e2ff978bdcaced06d70a274fb9216b commit 4f407ce208e2ff978bdcaced06d70a274fb9216b Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 21 18:55:25 2017 Fix Clang dEQP build on Win. Rolls the build/ repos from Chromium to include the fixed config. Also includes incidental improvements to platform-specific hooks. Bug: chromium:727437 Change-Id: Ia42a30acac1e800e593e304bfc59d86eb0a1e57c Reviewed-on: https://chromium-review.googlesource.com/782340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/4f407ce208e2ff978bdcaced06d70a274fb9216b/src/tests/BUILD.gn [modify] https://crrev.com/4f407ce208e2ff978bdcaced06d70a274fb9216b/DEPS
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/505de88083136eefd056e5ee4ca0f01fe9b33de8 commit 505de88083136eefd056e5ee4ca0f01fe9b33de8 Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 21 17:39:41 2017 Finish migration to exceptions configs. Bug: 727437 Change-Id: I9005f7922e5ba593df9289d4650d1f53238bd16d Tbr: glider@chromium.org [modify] https://crrev.com/505de88083136eefd056e5ee4ca0f01fe9b33de8/third_party/libunwind/BUILD.gn [modify] https://crrev.com/505de88083136eefd056e5ee4ca0f01fe9b33de8/third_party/libc++/BUILD.gn [modify] https://crrev.com/505de88083136eefd056e5ee4ca0f01fe9b33de8/third_party/libc++abi/BUILD.gn
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/086ae8199326b598c6a6eb2f4779de042c70f043 commit 086ae8199326b598c6a6eb2f4779de042c70f043 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 22 05:53:34 2017 Roll src/buildtools/ 461b345a8..505de8808 (1 commit) https://chromium.googlesource.com/chromium/buildtools.git/+log/461b345a815c..505de8808313 $ git log 461b345a8..505de8808 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 jmadill Finish migration to exceptions configs. Created with: roll-dep src/buildtools Tbr: brettw@chromium.org Bug: 727437 Change-Id: Iccaba58f3e223ac50b9551872dca2f4bb7cddcc4 Reviewed-on: https://chromium-review.googlesource.com/784278 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#518547} [modify] https://crrev.com/086ae8199326b598c6a6eb2f4779de042c70f043/DEPS
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d8ab22589487273c50a5d9483867b88597385b7 commit 1d8ab22589487273c50a5d9483867b88597385b7 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 22 18:51:00 2017 Remove temporary config for ANGLE build transition. This completes the transition to exceptions configs. Bug: 727437 Tbr: brettw@chromium.org Change-Id: I912296e99f399fdf1d96304a54399bb864563642 Reviewed-on: https://chromium-review.googlesource.com/785552 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#518695} [delete] https://crrev.com/ed7d4d2822d2974339093df4656c87dc2789d5bf/build/config/angle_temp.gni [modify] https://crrev.com/1d8ab22589487273c50a5d9483867b88597385b7/build/config/compiler/BUILD.gn
,
Nov 22 2017
All work here complete for now.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 commit a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 13 20:02:23 2018 Switch deqp windows bots to use clang. deqp used to not build with clang, but nowadays it does. We wanted to wait with the switch until we can pin clang on the deqp bots to an older clang if necessary, but we already don't do that on mac and linux, so this doesn't make things any worse, and it removes one blocker for the msvc bot turndown and makes the deqp bots run tests with the compiler that we use for building shipping chromium. Bug: 727437 , 786460 Change-Id: I3bd76f7e2939e33b28262ca509259b37e8bbe582 Reviewed-on: https://chromium-review.googlesource.com/1012740 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550737} [modify] https://crrev.com/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5/tools/mb/mb_config.pyl
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 commit a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 13 20:02:23 2018 Switch deqp windows bots to use clang. deqp used to not build with clang, but nowadays it does. We wanted to wait with the switch until we can pin clang on the deqp bots to an older clang if necessary, but we already don't do that on mac and linux, so this doesn't make things any worse, and it removes one blocker for the msvc bot turndown and makes the deqp bots run tests with the compiler that we use for building shipping chromium. Bug: 727437 , 786460 Change-Id: I3bd76f7e2939e33b28262ca509259b37e8bbe582 Reviewed-on: https://chromium-review.googlesource.com/1012740 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550737} [modify] https://crrev.com/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5/tools/mb/mb_config.pyl |
||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, May 30 2017