New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727436 link

Starred by 1 user
Status: Fixed
Owner:
goog...@chromium.org
Closed: Mar 2018
Cc:
█ clingon@google.com
goog...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 703887
issue 720184


Sign in to add a comment

Compact Clank Translate UI code cleanup

Project Member Reported by goog...@chromium.org, May 30 2017 
Compact Clank Translate UI is implemented on M60.

Once the new feature becomes stable, we should start a code cleanup to remove unused code and refactor some modules to make the code as reusable as possible or optimize the performance.

Eg. 

* Move java side logging to translate_compact_infobar to reduce the native calls.
* Remove old translate infobar once we decide to upgrade.
* Refactor translate_infobar_delegate to centralize logic. 
* Add as many unittests as possible.
...

Comment 2 by yyushkina@chromium.org, Sep 5 2017

Cc: goog...@chromium.org
 Issue 748321  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53cafe44ebba1e685e251714aff7e77f981f8f83

commit 53cafe44ebba1e685e251714aff7e77f981f8f83
Author: Leo Zhang <googleo@chromium.org>
Date: Wed Jan 03 02:34:26 2018

Code cleanup for translate infobar.

This CL removes legacy translate infobar code which includes:
  * Old UI entry on Android and its sub panels
  * Native for the old Android UI
  * Tests for the old UI

Bug:  727436 
Change-Id: I9e98fcc763c110ea07832abbfa06a7a9dbd7a200
Reviewed-on: https://chromium-review.googlesource.com/838760
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526596}
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateNeverPanel.java
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSubPanel.java
[modify] https://crrev.com/53cafe44ebba1e685e251714aff7e77f981f8f83/chrome/android/java_sources.gni
[modify] https://crrev.com/53cafe44ebba1e685e251714aff7e77f981f8f83/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java
[modify] https://crrev.com/53cafe44ebba1e685e251714aff7e77f981f8f83/chrome/browser/BUILD.gn
[modify] https://crrev.com/53cafe44ebba1e685e251714aff7e77f981f8f83/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/53cafe44ebba1e685e251714aff7e77f981f8f83/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/browser/ui/android/infobars/translate_infobar.cc
[delete] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/chrome/browser/ui/android/infobars/translate_infobar.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8978bb4b2ee8f7bda17209d340ac76a49de347

commit ab8978bb4b2ee8f7bda17209d340ac76a49de347
Author: Leo Zhang <googleo@chromium.org>
Date: Wed Jan 03 03:56:40 2018

Remove compact translate UI flag from chrome://flags.

Bug:  727436 
Change-Id: I2ca1864627998febcae1cbd68c5a4308481fd5ad
Reviewed-on: https://chromium-review.googlesource.com/838800
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526613}
[modify] https://crrev.com/ab8978bb4b2ee8f7bda17209d340ac76a49de347/chrome/browser/about_flags.cc
[modify] https://crrev.com/ab8978bb4b2ee8f7bda17209d340ac76a49de347/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ab8978bb4b2ee8f7bda17209d340ac76a49de347/chrome/browser/flag_descriptions.h

Comment 5 by yyushkina@chromium.org, Mar 7 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment