New issue
Advanced search Search tips

Issue 727432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't show error label for intl phone form a different country than the profile.

Project Member Reported by se...@chromium.org, May 30 2017

Issue description

Comment 2 by se...@chromium.org, Jun 1 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch ASAP.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d49fb2845a1c579c67dd41132319e8f4eabbfac

commit 9d49fb2845a1c579c67dd41132319e8f4eabbfac
Author: sebsg <sebsg@chromium.org>
Date: Fri Jun 02 15:02:51 2017

Merge-60 [Payments] Don't show error for intl phone from other country.

BUG= 727432 

Review-Url: https://codereview.chromium.org/2911973002
Cr-Original-Commit-Position: refs/heads/master@{#476028}
Review-Url: https://codereview.chromium.org/2916313002 .
Cr-Commit-Position: refs/branch-heads/3112@{#114}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/9d49fb2845a1c579c67dd41132319e8f4eabbfac/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/9d49fb2845a1c579c67dd41132319e8f4eabbfac/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/9d49fb2845a1c579c67dd41132319e8f4eabbfac/components/payments/core/payments_profile_comparator.cc

Comment 6 by se...@chromium.org, Jun 2 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M60 TE-Verified-60.0.3112.20
Tested the issue on Windows 7, Mac 10.12.4, Linux Ubuntu 14.04 using chrome version#60.0.3112.20 with the steps mentioned in  issue#723294 ,comment #22 .

Observed that the user able to save the address as per the intended behavior in the below URL:
https://rsolomakhin.github.io/pr/single/

Hence adding TE-Verified labels.Please find the attached screen cast for the same.

Thanks!!
727432.mp4
2.2 MB View Download
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment