New issue
Advanced search Search tips

Issue 727427 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Add support for DCHECKing an empty WebStateList on TabGrid and Toolbar Mediators.

Project Member Reported by sczs@chromium.org, May 30 2017

Issue description

Currently there are some codepaths where the WSL property is being set as nil, this should be a programmer error and we should DCHECK().

For more context see:
https://codereview.chromium.org/2908623004/diff/20001/ios/clean/chrome/browser/ui/toolbar/toolbar_mediator.mm

Ed, I'm assigning to you on the meantime since you tackled the issue along Rohit before and came up with the disconnect pattern. 

I can help with anything you need, or we can also re-assign.
 
Components: -Internals UI>Browser>Toolbar
Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Status: WontFix (was: Assigned)
This comment is no longer relevant since the referenced code is in clean.

Sign in to add a comment