New issue
Advanced search Search tips

Issue 727394 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

All PDFium trybots broken in bot_update

Project Member Reported by dsinclair@chromium.org, May 29 2017

Issue description

All of the try-bots for PDFium have gone purple with failed bot_updates [1]

Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 2295, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 2281, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 2030, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 1340, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient_utils.py", line 1047, in run
    self.item.run(*self.args, **self.kwargs)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 766, in run
    self.ParseDepsFile()
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 562, in ParseDepsFile
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient_eval.py", line 236, in Check
    result_scope = _gclient_exec(content, global_scope, filename=path)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient_eval.py", line 181, in _gclient_exec
    _visit_in_module(stmt)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/gclient_eval.py", line 177, in _visit_in_module
    getattr(node, 'lineno', '<unknown>')))
ValueError: unexpected AST node: <_ast.Import object at 0x7f6c2ea203d0> Import(names=[alias(name='os', asname=None)]) (file '/b/build/slave/linux_xfa/build/pdfium/third_party/skia/DEPS', line 50)
===Failed in 0.1 mins===

Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1141, in <module>
    sys.exit(main())
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1125, in main
    checkout(options, git_slns, specs, revisions, step_text, shallow)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1045, in checkout
    gclient_output = ensure_checkout(**checkout_parameters)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 805, in ensure_checkout
    break_repo_locks)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 356, in gclient_sync
    raise GclientSyncFailed(e.message, e.code, e.output)
__main__.GclientSyncFailed: /usr/bin/python -u /b/build/scripts/slave/.recipe_deps/depot_tools/gclient.py sync --verbose --reset --force --ignore_locks --output-json /tmp/tmpFW7mT5.json --nohooks --noprehooks --delete_unversioned_trees --revision pdfium@unmanaged failed with code 1 in /b/build/slave/linux_xfa/build.
step returned non-zero exit code: 1


1- https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/builds/5157/steps/bot_update/logs/stdio
 
Owner: dsinclair@chromium.org
Status: Assigned (was: Unconfirmed)
Looks like PDFium needs to roll DEPS for Skia in order to get the new Skia DEPS file which passes validation.
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/b58ff22b729a9b141a7d735254ffa2cbf3ce2b22

commit b58ff22b729a9b141a7d735254ffa2cbf3ce2b22
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Tue May 30 13:42:11 2017

Roll skia to fix bots

The version of Skia we are using does not pass the new DEPS file
validation. This CL syncs to the latest Skia in order to fix the DEPS
issue.

TBR=tsepez@chromium.org
Bug:  chromium:727394 ,  chromium:570091 
Change-Id: Id475ff5c98e1bc75ee76fdfc44df972ef1d53cc8
Reviewed-on: https://pdfium-review.googlesource.com/6076
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/b58ff22b729a9b141a7d735254ffa2cbf3ce2b22/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment