New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 570091



Sign in to add a comment

Assert failure for gclient sync for clank

Project Member Reported by wnwen@chromium.org, May 29 2017

Issue description

Failure running 'gclient sync' under src

src/clank (ERROR)
----------------------------------------
[0:00:00] Started.
[0:00:00] ________ unmanaged solution; skipping src/clank
----------------------------------------
Traceback (most recent call last):
  File "/Work/depot_tools/gclient.py", line 2293, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/Work/depot_tools/gclient.py", line 2279, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/Work/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/Work/depot_tools/gclient.py", line 2028, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/Work/depot_tools/gclient.py", line 1338, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/Work/depot_tools/gclient_utils.py", line 1047, in run
    self.item.run(*self.args, **self.kwargs)
  File "/Work/depot_tools/gclient.py", line 764, in run
    self.ParseDepsFile()
  File "/Work/depot_tools/gclient.py", line 658, in ParseDepsFile
    assert isinstance(dep_value, dict)
AssertionError

My .gclient file

solutions = [
 { "name"        : "src/clank",
   "url"         : "https://chrome-internal.googlesource.com/clank/internal/apps.git",
   "deps_file"   : ".DEPS.git",
   "managed"     : False,
   "custom_deps" : {
     'src/third_party/adobe/flash/binaries/ppapi/linux': None,
     'src/third_party/adobe/flash/binaries/ppapi/linux_x64': None,
     'src/third_party/adobe/flash/symbols/ppapi/linux': None,
     'src/third_party/adobe/flash/symbols/ppapi/linux_x64': None,
   },
   "custom_vars" : {"chromium_rev": "unmanaged"},
   "safesync_url": ""
 },
]
cache_dir = None
 

Comment 1 by wnwen@chromium.org, May 29 2017

Components: Infra
Project Member

Comment 2 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/1101645d533f44d3fe650d1635fa4bbe2b6eb716

commit 1101645d533f44d3fe650d1635fa4bbe2b6eb716
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Mon May 29 16:19:03 2017

gclient: fix assertion crash when a dep is set to None

This is a follow-up after https://chromium-review.googlesource.com/c/517049/

Bug:  727334 ,  570091 
Change-Id: I49f9ad07f1b79cba547d88e93b2d2064c33e1f4b
Reviewed-on: https://chromium-review.googlesource.com/518125
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/1101645d533f44d3fe650d1635fa4bbe2b6eb716/testing_support/fake_repos.py
[modify] https://crrev.com/1101645d533f44d3fe650d1635fa4bbe2b6eb716/gclient.py

Status: Fixed (was: Assigned)
Blocking: 570091

Sign in to add a comment