New issue
Advanced search Search tips

Issue 727329 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Possible case issue with BrowsingDataUtilsTest.PasswordsCounterResult

Project Member Reported by mattcary@chromium.org, May 29 2017

Issue description

BrowsingDataUtilsTest.PasswordsCounterResult has started failing on android:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndroid_N5X_Swarm_Builder%2F12708%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests_on_Android%2F0%2Flogs%2FBrowsingDataUtilsTest.PasswordsCounterResult%2F0

It appears that the problem is that the tests expects the output to be "none", but is getting "None" instead. Looking a the message definition, it indeed appears that we do expect the message to be "none": https://cs.chromium.org/chromium/src/components/browsing_data_strings.grdp?rcl=dc4425ad0170e20b9dae7653c89f55defc1bde83&l=34

This has exhausted my very limited knowledge of l10n & i18n.

+dullweber@: you've recently touched this test, perhaps you know what's going on?

Thanks
 
I just changed the string from "none" to "None". It seems like the test didn't get executed when I submitted the cl (https://codereview.chromium.org/2910983002)
Looks like it's been reverted: crrev.com/2911923002
Status: Fixed (was: Untriaged)

Sign in to add a comment