New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Report watch time for video display type (inline/fullscreen/picture-in-picture)

Project Member Reported by mlamouri@chromium.org, May 29 2017

Issue description

This would only apply to AudioVideo watch time and would allow to know how much of it is inline, in fullscreen or in picture-in-picture. It can be particularly useful on mobile where there would be a significant difference in experience between the three different display types.
 
Summary: Report watch time for video display type (inline/fullscreen/picture-in-picture) (was: Report watch time for video display type (inline/fullscreen/picture-in-pi)
Description: Show this description
Cc: dalecur...@chromium.org
Components: Internals>Media
Labels: -OS-Linux -Pri-3 M-60 OS-All Pri-2
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
Could remote playback be a display type too?
Cc: avayvod@chromium.org
I'm not sure it makes sense to have remote as display type: I would put this to a different bucket. This said, the Watch Time Reporter is linked to WMPI so we would unlikely record watch time for remote playback.

IMO, it might be nice to have a "Remote" sub-category for watch time, the same way we have "Background".
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9af74e761a9ff05a6d2b42197a961b439cc10b7

commit f9af74e761a9ff05a6d2b42197a961b439cc10b7
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jun 20 23:38:02 2017

Watch Time: report watch time based on display type.

Different types are: inline, fullscreen and picture-in-picture.

Bug:  727322 
Change-Id: I72bfa1a1f8f46079880f60cfd5b5d886875d06d6
Reviewed-on: https://chromium-review.googlesource.com/528082
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481025}
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/browser/media/media_internals.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/browser/media/media_internals_unittest.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/base/watch_time_keys.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/base/watch_time_keys.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLVideoElement.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/public/platform/WebMediaPlayer.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/public/platform/WebMediaPlayerClient.h
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/tools/metrics/ukm/ukm.xml

Labels: Merge-Request-60
Status: Started (was: Assigned)
The CL might look big but it's mostly mechanical. We would like to have this in Beta in order to be able to estimate the impact of a feature that we are about to launch in 61.
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 21 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Rejected-60
Since this is late for M60, we are only considering bug-regression fixes and critical security bugs. All feature implementations/enabling should be considered for next milestone. 
Status: Fixed (was: Started)
Fair enough :)
Labels: -M-60 M-61

Sign in to add a comment