Report watch time for video display type (inline/fullscreen/picture-in-picture) |
|||||||||
Issue descriptionThis would only apply to AudioVideo watch time and would allow to know how much of it is inline, in fullscreen or in picture-in-picture. It can be particularly useful on mobile where there would be a significant difference in experience between the three different display types.
,
May 29 2017
,
May 29 2017
,
May 29 2017
Could remote playback be a display type too?
,
May 30 2017
I'm not sure it makes sense to have remote as display type: I would put this to a different bucket. This said, the Watch Time Reporter is linked to WMPI so we would unlikely record watch time for remote playback. IMO, it might be nice to have a "Remote" sub-category for watch time, the same way we have "Background".
,
Jun 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9af74e761a9ff05a6d2b42197a961b439cc10b7 commit f9af74e761a9ff05a6d2b42197a961b439cc10b7 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Jun 20 23:38:02 2017 Watch Time: report watch time based on display type. Different types are: inline, fullscreen and picture-in-picture. Bug: 727322 Change-Id: I72bfa1a1f8f46079880f60cfd5b5d886875d06d6 Reviewed-on: https://chromium-review.googlesource.com/528082 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#481025} [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/browser/media/media_internals.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/content/renderer/media/webmediaplayer_ms_unittest.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/base/watch_time_keys.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/base/watch_time_keys.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/watch_time_reporter_unittest.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/Source/core/html/HTMLVideoElement.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/public/platform/WebMediaPlayer.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/third_party/WebKit/public/platform/WebMediaPlayerClient.h [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/f9af74e761a9ff05a6d2b42197a961b439cc10b7/tools/metrics/ukm/ukm.xml
,
Jun 21 2017
The CL might look big but it's mostly mechanical. We would like to have this in Beta in order to be able to estimate the impact of a feature that we are about to launch in 61.
,
Jun 21 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2017
Since this is late for M60, we are only considering bug-regression fixes and critical security bugs. All feature implementations/enabling should be considered for next milestone.
,
Jun 23 2017
Fair enough :)
,
Jun 23 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mlamouri@chromium.org
, May 29 2017