Search bar disappears on hitting space key on chrome browser.
Reported by
sanchit....@gmail.com,
May 29 2017
|
|||||||||||||
Issue descriptionHi, My name is Sanchit and I am studying Information Engineering in Hamburg University of Applied Sciences. I experienced a really strange thing today in google chrome web search, when I hit a space at first in the search bar it automatically disappears and it will appear agin on manual clicks. To make sure that it is a browser bug I went to a different browser (Safari) and opened chrome but everything works perfectly fine. I am attaching a screenshot of the current situation. Please fix it if it is a bug & if not then let me know. Regards Sanchit Bhavsar
,
Jun 3 2017
Hello, first of all, I posted for wrong OS platform I am using Windows not Android. The main issue is on chrome browser. Btw I am using lenovo G50 with Windows 10. I tried on MacOS too and still the same problem, the browser search disappears on pressing space button.
,
Jun 3 2017
Thank you for providing more feedback. Adding requester "ppolisetty@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
,
Jun 12 2017
I can reproduce. I can also confirm that this is working as intended but it *is* confusing. The WAI part is that the search box in the middle of the new tab page is *supposed* to disappear on keyboard input. This is because focus has moved to the Chrome omnibox at the top of the window. Normally, this is totally obvious because the suggestion list appears, drawing your attention to the top of the window where your input and the cursor now appears. But in the case of entering a space, it's far less obvious (it looked like a bug to me at first, too). There's no visible input in the omnibox and there are no suggestions. The only thing you really notice is that the search box and Google logo have disappeared somewhat mysteriously. pkasting: any thoughts on this? Has this case been discussed previously? Maybe we should open an empty suggestion list on whitespace input in order to make clear that the omnibox received your input?
,
Jun 12 2017
Yes, this is looks weird. I think the simplest solution is to ignore the space if the fakebox has focus. (Keep showing the search engine logo and fakebox.) Slightly better might be remember the user pressed space (and how many times) so that when the user types a real character, we can display the right thing (spaces + character) in the omnibox itself (while hiding the search engine logo and fakebox) Another possibility is to immediately enter query mode upon typing the space, i.e., display the "Search Google:" in the omnibox. I think this is also a reasonable option because if the user explicitly focused the box below the search engine logo and starts typing, and in particular starts typing something that doesn't appear in a URL (a space), the user is likely intending to do a search.
,
Jun 13 2017
@mpear I also think setting-up a query for space input is a convenient way but do notice that even when a user type space in the Omnibox, the space is shown in the URL.
,
Oct 13 2017
Hello, What is the update on this issue
,
Oct 13 2017
There is no update. We recognize this is an issue. However, it's minor, and we haven't gotten around to fixing it yet. If you are a programmer and want to contribute to chromium, you're certainly welcome to submit code to fix it. :-)
,
Oct 17 2017
I think the simplest solution is the best. Just ignore spaces in the fakebox and don't try to remember them or do anything with them. Leading spaces are ignored for suggestions, issuing queries and even navigating to URLs. Since you can enter space(s) and then either a query or a URL I don't think we should assume query mode is desired, especially since a likely reason someone typed a space first is that they just accidentally bumped the space bar on their keyboard.
,
Apr 13 2018
,
May 17 2018
Removing Restrict-View-Google, as I don't think there's anything confidential in here. I'm not sure why it was applied.
,
May 17 2018
,
May 17 2018
Issue 841808 has been merged into this issue.
,
May 17 2018
,
Jul 4
I can try to work on this!
,
Jul 4
Note that crbug.com/847673 retains the search engine logo or doodle when a user starts typing in the fakebox. This is available in M69 (current Canary). Typing leading spaces still shifts focus to the omnibox.
,
Jul 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51d7d8c93f1ea6d42cc49397b765be90e5aaf667 commit 51d7d8c93f1ea6d42cc49397b765be90e5aaf667 Author: Jeffrey <jeffreyca16@gmail.com> Date: Sun Jul 15 16:53:23 2018 Ignore whitespace input in fakebox when focused This change fixes the bug from the omnibox side. When the fakebox is focused, the omnibox will be in an "invisible focus" state. So these changes prevent the focus state to change if whitespace is inputted or pasted into the fakebox. The existing behaviour for dragging whitespace text into the fakebox does not hide the fakebox. That was not changed. A small change was made to the fakebox cursor, so when the fakebox is hidden, hovering over that area shows the default cursor instead of the text cursor. R=ramyan@chromium.org, treib@chromium.org Bug: 727302 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id075e3e52113d5e8e27e2e1bab74926a6b8bc723 Reviewed-on: https://chromium-review.googlesource.com/1127488 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#575188} [modify] https://crrev.com/51d7d8c93f1ea6d42cc49397b765be90e5aaf667/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/51d7d8c93f1ea6d42cc49397b765be90e5aaf667/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Jul 16
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Tested the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using latest chrome version #69.0.3493.0 as per the comment #0. Attaching screen cast for reference. Observed that on OS-mac the search bar still disappears on hitting space key on chrome browser, whereas on OS-win and OS-linux, the search bar did not disappear on hitting space key on chrome browser. ramyan@/treib@ - Could you please check the attached screen cast on OS-mac and please help us in confirming the fix. Thanks...!!
,
Jul 16
Can you confirm it's fixed in MacViews? Should it be fixed in both MacViews and Cocoa?
,
Jul 17
To address this in the Cocoa version it uses omnibox_view_mac.mm instead of omnibox_view_views.cc. In omnibox_view_mac.mm there's a OnPaste() function which can be updated with the whitespace check. However for keyboard input, the OnInsertText() does not take any arguments so there's no way to check the inputted character. OnInsertText() is called in autocomplete_text_field_editor.mm's insertText(), but cannot check the Omnibox's model focus state from there. Any suggestions on how to tackle this?
,
Aug 2
Let's re-evaluate this once Views and MacViews settles down in M-69.
,
Oct 12
The NextAction date has arrived: 2018-10-12
,
Nov 1
Can this be closed?
,
Nov 1
MacViews has launched, this issue no longer appears on any platform. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ppolise...@chromium.org
, Jun 2 2017