LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt is gone; adding it back not working as expected |
||||||||||
Issue descriptionhttps://codereview.chromium.org/2642873002/ deleted this file. Adding it back, it is actually identical to LayoutTests/webexposed/global-interface-listing-expected.txt, in other words it's somehow running with experimental features enabled. The workers tests do not have this problem. We need this in order to catch things accidentally shipping to stable. Tentatively assigning to alokp@ who removed it, can you investigate and reassign if necessary?
,
May 30 2017
,
Jun 5 2017
I think somebody more familiar with layout test infrastructure should look into this. For https://codereview.chromium.org/2642873002, I did not manually delete this file. I just used automated rebaseline tool documented here: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_test_expectations.md#Rebaselining-using-try-jobs
,
Jun 5 2017
rbyers@, can you find an owner?
,
Jun 6 2017
I'm interested in any problems with rebaselining, so maybe I should own this :-D To try to clarify what happened during the rebaselining in that CL: Before that CL, there were these baselines: LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt After that CL, there were these baselines: LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt So, either way, there are separate platform-specific baselines for linux, win, and mac. These baselines were updated based on results in the try jobs for patch 7, e.g.: https://storage.googleapis.com/chromium-layout-test-archives/win10_blink_rel/1808/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_blink_rel/1749/layout-test-results/results.html But, if I understand this bug correctly, the issue is that that "virtual/stable/webexposed/global-interface-listing.html" shouldn't have failed at all in those try jobs -- that CL shouldn't have caused the results of "vitual/stable/webexposed/global-interface-listing.html" to change -- is that right?
,
Jun 22 2017
The repro steps for this bug is trying to flip a feature from experimental to stable, and seeing if that results in any changes to webexposed files that require review from API_OWNERS. It seems like it didn't, and as long as it does it's less important which specific files it is.
,
Jul 3 2017
,
Jul 3 2017
,
Aug 3 2017
This P1 issue is >30 days old and came up in triage. I don't think it's actually a P1, downgrading. Nevertheless, any progress on this?
,
Aug 17 2017
I haven't actually investigated this... Marking as available now.
,
Oct 19 2017
Hit the >60 day mark for triage. (Unfortunately I'm not likely to make progress on it today)
,
Dec 19 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by foolip@chromium.org
, May 29 2017