New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727286 link

Starred by 1 user
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Enable all PageLoadMetricsObservers to record UKM data

Project Member Reported by bmcquade@chromium.org, May 29 2017 
The current PLM UKM implementation allocates a UKM SourceId in the UKM observer.

We'd like to move SourceId generation to PageLoadTracker, so all observers can share a single SourceId.

Ryan Sturm wrote a doc with more details here:
https://docs.google.com/document/d/1zLLKPe1IwX-WEAjtVSLBwLvcyXm1Io527ZQi7m_wu1M/edit
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bff3c633799c676eadce377337cc24a27795151

commit 0bff3c633799c676eadce377337cc24a27795151
Author: bmcquade <bmcquade@chromium.org>
Date: Tue May 30 18:31:44 2017

Move UKM PageLoad SourceId generation to PageLoadTracker.

We'd like to enable all observers to record UKM data sharing the same SourceId,
so metrics from different observers can be queried/joined together.

This change migrates SourceId generation from the UKM observer to the
PageLoadTracker, so all observers can share the same SourceId.

BUG= 727286 

Review-Url: https://codereview.chromium.org/2909033002
Cr-Commit-Position: refs/heads/master@{#475606}

[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/google_captcha_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/0bff3c633799c676eadce377337cc24a27795151/chrome/browser/page_load_metrics/page_load_tracker.h

Comment 2 by bmcquade@chromium.org, May 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment