New issue
Advanced search Search tips

Issue 727285 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 719108



Sign in to add a comment

Unship NetworkInformation#effectiveType and merge to M60

Project Member Reported by foolip@chromium.org, May 29 2017

Issue description

In https://codereview.chromium.org/2883763002/ it looks like it was shipped accidentally, see comment there.
 
Labels: -Pri-2 OS-All Pri-1
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/777d7bc8272145d4221ed2428ca8e3680421c624

commit 777d7bc8272145d4221ed2428ca8e3680421c624
Author: tbansal <tbansal@chromium.org>
Date: Tue May 30 03:34:30 2017

Condition effectiveType as RuntimeEnabled feature

This was missed by mistake in a previous CL.

BUG= 727285 

Review-Url: https://codereview.chromium.org/2908203002
Cr-Commit-Position: refs/heads/master@{#475416}

[modify] https://crrev.com/777d7bc8272145d4221ed2428ca8e3680421c624/third_party/WebKit/Source/modules/netinfo/NetworkInformation.idl

Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, May 31 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch before 4.00 PM PST(05/31) to make it to next release.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2aa02b5604d12485373600896d4dd84c4ef2db8

commit f2aa02b5604d12485373600896d4dd84c4ef2db8
Author: Tarun Bansal <tbansal@google.com>
Date: Thu Jun 01 06:43:22 2017

Condition effectiveType as RuntimeEnabled feature

This was missed by mistake in a previous CL.

BUG= 727285 

Review-Url: https://codereview.chromium.org/2908203002
Cr-Original-Commit-Position: refs/heads/master@{#475416}
Review-Url: https://codereview.chromium.org/2915773004 .
Cr-Commit-Position: refs/branch-heads/3112@{#81}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/f2aa02b5604d12485373600896d4dd84c4ef2db8/third_party/WebKit/Source/modules/netinfo/NetworkInformation.idl

Status: Fixed (was: Started)

Sign in to add a comment