ProgressDialog in CBD on Android flashes when a deletion is very fast |
|
Issue descriptionFast deletions make the ProgressDialog flash for a very short moment and then disappear. This looks bad and should be fixed by introducing timeouts like "show the dialog only after X ms" and "show for at least Y ms".
,
May 30 2017
I would be a bit careful about applying the counter behavior so straightforwardly here. Counters are a secondary feature, and you don't have to wait for them to finish. Deletion is the primary feature, and it's blocking. I'm not sure if making the product slower so that it's visually more pleasing is a good idea. I'm open to try it, but please let's add a histogram for an "unnecessarily shown dialog", i.e. for the deletion time 140-4000. Alternatively, note that we changed the MD CBD on Desktop to not wait for deletion (https://codereview.chromium.org/2315443002), which seems to have worked fine so far, although MD settings have been behind a flag most of the time, so we probably don't have enough data yet to tell if people mind that data are still being deleted while they browse.
,
May 30 2017
That's a good point. Avoiding any blocking UI would be preferable over this option. Are there any technical differences on Android that would prevent us from adapting the Desktop behavior?
,
May 30 2017
It could be an issue if you open the CBD dialog from history and select to delete all your history. When you click "Clear Data", you will go back to the history dialog but it might still show history entries if the deletion didn't finish?
,
May 30 2017
The backend is the same, so this will work on Android as well. But this is a somewhat fundamental change in behavior, so I wouldn't recommend merging it. Given that this is not a regression, can we make the change one milestone later?
,
May 30 2017
Sounds good! This will give us some time to think about other non-blocking options like snackbars. Should we still add the histogram to learn more about deletion times in the meantime?
,
Jan 12 2018
Issue 801241 has been merged into this issue. |
|
►
Sign in to add a comment |
|
Comment 1 by maxwalker@chromium.org
, May 29 2017156 KB
156 KB View Download