New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727235 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Camera app launches in a position where the close button is not visible

Project Member Reported by satorux@chromium.org, May 29 2017

Issue description

Chrome Version       : 61.0.3115.0
OS Version: 9536.0.0


What steps will reproduce the problem?
1. Open Camera app on Daisy device

What is the expected result?

Camera app launches in a position where the entire window fits in the screen


What happens instead of that?

Camera apps launches in a position where the close button is not visible (i.e. the window title bar is above the upper bound of the screen).

You have to press Ctrl-W to close the app.
 
Summary: Camera app launches in a position where the close button is not visible (was: Came app launches in a position where the close button is not visible)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/975a750812433ab4aac4b50cda8a4582b2a41df7

commit 975a750812433ab4aac4b50cda8a4582b2a41df7
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Thu Jun 15 06:08:39 2017

Fix window positioning.

This CL fixes numerous issues with window positioning.
1. The window could get out of screen on first launch.
2. The window could get out of screen when switching cameras.
3. The window could be snapped to aspect ratio when user didn't want.
4. The window could get behind the overlay shelf making it hard to take
   pictures, as the button is on the bottom.
5. Migrate from obsolete bounds() to innerBounds and outerBounds.

TEST=Tested manually on Lucas.
BUG= chromium:727235 
Change-Id: Ie3707c1e4883300a6cfd563f2045c7589ebab4b7
Reviewed-on: https://chromium-review.googlesource.com/517688
Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>

[modify] https://crrev.com/975a750812433ab4aac4b50cda8a4582b2a41df7/src/js/views/camera.js
[modify] https://crrev.com/975a750812433ab4aac4b50cda8a4582b2a41df7/src/js/background.js

Status: Fixed (was: Started)
Fixed in Camera app 4.7.0 being rolled out now.

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975a750812433ab4aac4b50cda8a4582b2a41df7

commit 975a750812433ab4aac4b50cda8a4582b2a41df7
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Thu Jun 15 06:08:39 2017

Fix window positioning.

This CL fixes numerous issues with window positioning.
1. The window could get out of screen on first launch.
2. The window could get out of screen when switching cameras.
3. The window could be snapped to aspect ratio when user didn't want.
4. The window could get behind the overlay shelf making it hard to take
   pictures, as the button is on the bottom.
5. Migrate from obsolete bounds() to innerBounds and outerBounds.

TEST=Tested manually on Lucas.
BUG= chromium:727235 
Change-Id: Ie3707c1e4883300a6cfd563f2045c7589ebab4b7
Reviewed-on: https://chromium-review.googlesource.com/517688
Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>

[modify] https://crrev.com/975a750812433ab4aac4b50cda8a4582b2a41df7/src/js/background.js
[modify] https://crrev.com/975a750812433ab4aac4b50cda8a4582b2a41df7/src/js/views/camera.js

Project Member

Comment 7 by bugdroid, Today (74 minutes ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce49357b184a751a55df5b61e2aec4fb9a96ad9b

commit ce49357b184a751a55df5b61e2aec4fb9a96ad9b
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Thu Jun 15 06:08:39 2017

Fix window positioning.

This CL fixes numerous issues with window positioning.
1. The window could get out of screen on first launch.
2. The window could get out of screen when switching cameras.
3. The window could be snapped to aspect ratio when user didn't want.
4. The window could get behind the overlay shelf making it hard to take
   pictures, as the button is on the bottom.
5. Migrate from obsolete bounds() to innerBounds and outerBounds.

TEST=Tested manually on Lucas.
BUG= chromium:727235 
Change-Id: Ie3707c1e4883300a6cfd563f2045c7589ebab4b7
Reviewed-on: https://chromium-review.googlesource.com/517688
Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>


Sign in to add a comment