New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727190 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : [md-settings] Unwanted vertical and horizontal scrollbars are observed in all the dialogs.

Reported by avsha...@etouch.net, May 29 2017 
Chrome Version : 61.0.3114.0 (Official Build) cf4f838225c132dee06cc21dd6a576347734589b-refs/heads/master@{#475229} 32/64 bit
OS : Windows (7,8,10), Linux (14.04 LTS), Mac(10.12.3, 10.11.6)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/searchEngines.
2. In 'Other search engine' section, click on 'ADD' button and observe the 'Add search engine' dialog.

Actual : Unwanted vertical and horizontal scrollbars are observed on all the dialog boxes in md-settings. 

Expected : Instead, dialog scrollbars should only appear whenever browser window is resized. 

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3113.0
Bad build : 61.0.3114.0
Actual_dialog_boxe.mp4
1.0 MB View Download
Expected_dialog_box.mp4
865 KB View Download

Comment 1 by rbasuvula@chromium.org, May 29 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3113.0 (Revision:475196).
Bad build:61.0.3114.0 (Revision:475229).

You are probably looking for a change made after 475209 (known good), but no later than 475210 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/c61e0b14d96fcb5c4592d2c12551994f879e5490..a28228813e02d31eb1fb50ec263594e5cad1b80a

From the CL above, assigning the issue to the concern owner

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2908583002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3114.0

Comment 2 by scottchen@chromium.org, May 31 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da880a492cedc5c7a612180e84cd5527ae2f0b3

commit 0da880a492cedc5c7a612180e84cd5527ae2f0b3
Author: scottchen <scottchen@chromium.org>
Date: Thu Jun 01 00:13:02 2017

WebUI: Fix dialog showing unnecessary scrollbars

BUG= 727190 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915903002
Cr-Commit-Position: refs/heads/master@{#476105}

[modify] https://crrev.com/0da880a492cedc5c7a612180e84cd5527ae2f0b3/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 4 by scottchen@chromium.org, Jun 2 2017

Labels: Merge-Request-60
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 5 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80f60621994a5de82d1d0bb4c80e25074f246a8

commit b80f60621994a5de82d1d0bb4c80e25074f246a8
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jun 05 22:48:27 2017

M60: WebUI: Fix dialog showing unnecessary scrollbars.

BUG= 727190 

Review-Url: https://codereview.chromium.org/2927483002 .
Cr-Commit-Position: refs/branch-heads/3112@{#169}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/b80f60621994a5de82d1d0bb4c80e25074f246a8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 8 by scottchen@chromium.org, Jun 6 2017

Status: Fixed (was: Started)

Comment 9 by msrchandra@chromium.org, Jun 6 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3112.20
Tested the issue on Latest Dev# 60.0.3112.20 on Windows, Mac and Linux and found to be fixed.
No scrollbars are present under chrome://md-settings/searchEngines. Hence adding TE-Verified labels.
Attaching screen cast for reference.
Thank You.
727190.ogv
886 KB View Download
►

Sign in to add a comment