New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727175 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add browser_test for uploading a file from My Drive

Project Member Reported by yamaguchi@chromium.org, May 29 2017

Issue description

Add a browser test which verifies uploading a file from Google Drive by a <form> element starts successfully.
This test will be a regression test case for Issue 709769.

The test should open a page containing a form like this:
<form action="dummy-noexist.cgi" method="post" enctype="multipart/form-data">
  <input name="file1" type="file">
  <input type="submit" value="SUBMIT">
</form>
and then attempt to upload a file in a folder under Google Drive.

 

Comment 1 by nasko@chromium.org, May 30 2017

Cc: nasko@chromium.org

Comment 2 by sashab@chromium.org, Feb 22 2018

Components: Platform>Apps>FileManager
Labels: CrOS-FilesApp-DriveSync

Comment 3 by sashab@chromium.org, Feb 28 2018

Labels: CrOSFilesFeature-DriveSync

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-DriveSync

Comment 5 by nasko@chromium.org, Mar 9 2018

It will be nice to get test coverage for this to avoid accidental breakage in the future. It has been 10 months since the bug was opened.

Comment 6 by sashab@chromium.org, Mar 11 2018

Components: -Platform>Apps>FileManager>Drive
Labels: CrOSFilesCategory-Testing M-67
Status: Available (was: Untriaged)
I agree, and we are focusing on adding tests as part of this release. Also, we are looking at changing the Drive implementation at some point so detecting regressions will be important.

Marking as P3 for M67.
Labels: -M-67 M-68
Cc: noel@chromium.org
Labels: -M-68

Comment 9 by noel@chromium.org, Apr 22 2018

Components: Tests>Missing
Soon, I will be asking on review: where is your test? how was this tested? do we have coverage for your change? etc because

"All patches should have a bug.  All patches should have a test, or be covered by existing tests."

Labels: Files-Fixit-2018

Sign in to add a comment