color: layout tests fail image->makeColorSpace when output color space has non-srgb transfer fn |
||
Issue description
To reproduce
1. Apply a bunch of in-flight patches (this is just a work log for me, sorry for the incomplete repro steps)
2. Run any of the layout tests with SW raster
images/color-profile-svg.html
images/size-failure.html
3. Fail at the DCHECK software_image_decode_cache.cc(590)] Check failed: image.
This is from the block
if (target_color_space) {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
"SoftwareImageDecodeCache::GetOriginalSizeImageDecode - "
"color conversion");
image = image->makeColorSpace(target_color_space,
SkTransferFunctionBehavior::kIgnore);
DCHECK(image);
}
The call to SkImage::makeColorSpace is failing.
I'll dig in to see where this is going wrong.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7b17ca967e855df93193b868a33e4ccf892c163 commit f7b17ca967e855df93193b868a33e4ccf892c163 Author: ccameron <ccameron@chromium.org> Date: Wed May 31 19:06:47 2017 cc: Allow SkImage::makeColorSpace to fail This can fail because of lazy-decode failing (this is tested by some layout tests, which started crashing with color correct rendering enabled). BUG= 727169 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2908143005 Cr-Commit-Position: refs/heads/master@{#475970} [modify] https://crrev.com/f7b17ca967e855df93193b868a33e4ccf892c163/cc/tiles/software_image_decode_cache.cc
,
May 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ccameron@chromium.org
, May 30 2017