New issue
Advanced search Search tips

Issue 727149 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 707721
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Modal dialogs fail to pop up on large multi-monitor setups

Reported by dfoxfra...@gmail.com, May 28 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
Run chromium on a large multi-monitor setup; mine consists of four 3840x2160 displays arranged 2x2. Take an action which causes chromium to display a modal pop-up dialog, such as uninstalling an extension by clicking the trash icon in chrome://extensions. 

What is the expected behavior?

What went wrong?
The pop-up dialog does not appear. Chromium appears to become unresponsive because the invisible dialog blocks interaction with the rest of the chromium UI.

Did this work before? N/A 

Chrome version: 57.0.2987.133  Channel: stable
OS Version: NixOS 17.03
Flash Version: 

Using the xrandr utility to disable two of the four monitors causes chromium to work normally with the dialog appearing as expected. Disabling GPU acceleration does not help.
 
I just figured out that this is HiDPI-related. If I run chromium with --force-device-scale-factor=1, the bug goes away regardless of monitor count.
Labels: TE-Hardware-Dependency
Cc: a...@chromium.org
Have this same issue with 2x4k setup; extremely annoying and confusing. Hitting escape will bail on the modal popup. I'm also runnning --force-device-scale-factor=2

+avi who has worked on modal dialogs and may know the right routing here.

Comment 4 by a...@chromium.org, Aug 17 2017

Owner: thomasanderson@chromium.org
Thomas—

More Linux dialog issues, but this is interesting. Dialogs don't show up at 2x but do at 1x.

Perhaps info for you to investigate with?
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2be8c44f3383dc069d3b298b2d978d6592af08b

commit b2be8c44f3383dc069d3b298b2d978d6592af08b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Aug 24 02:43:37 2017

Change per_host_zoom_levels preference keys to be deterministic

The implementation of GetHash() in chrome_zoom_level_prefs.cc had an
unwanted dependency on the standard library's implementation of
std::hash<std::string>.  The value returned by GetHash() was being
used as a key in user preference storage.  On Linux, the standard
library changed from libstdc++ to libc++, which resulted in loss of
zoom preferences.

This CL changes the key to be deterministic and migrates settings for
the old key to the new one.

BUG= 727149 
R=wjmaclean@chromium.org

Change-Id: I6978e44b03cee5a1b5884d76ce2041e21d4e73bf
Reviewed-on: https://chromium-review.googlesource.com/624909
Reviewed-by: W. James MacLean <wjmaclean@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496927}
[modify] https://crrev.com/b2be8c44f3383dc069d3b298b2d978d6592af08b/chrome/browser/profiles/host_zoom_map_browsertest.cc
[modify] https://crrev.com/b2be8c44f3383dc069d3b298b2d978d6592af08b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc
[modify] https://crrev.com/b2be8c44f3383dc069d3b298b2d978d6592af08b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h

Labels: Merge-Request-61
Labels: -Merge-Request-61

Comment 8 by a...@chromium.org, Aug 24 2017

Thomas, might this be related to  bug 707721 , bug 709685, or  bug 709679 ?
Mergedinto: 707721
Status: Duplicate (was: Unconfirmed)

Sign in to add a comment