New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727127 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Integer-overflow in SkIRect::width

Project Member Reported by ClusterFuzz, May 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5355316626849792

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkIRect::width
  SkCanvas::internalSaveLayer
  SkCanvas::saveLayer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=400445:400830

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5355316626849792


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>Skia
Labels: M-60 Test-Predator-Correct-CLs
Owner: brianosman@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: brianosman
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/944876f2745a62a839e49275daf93a0329372e67
Time: Fri Jun 17 20:43:27 2016
Lines 1180, 1189 of file SkCanvas.cpp which potentially caused crash are changed in this cl (frame #1, "SkCanvas::internalSaveLayer").
Minimum distance from crash line to modified line: 0. (file: SkCanvas.cpp, crashed on: 1180, modified: 1180). 

Author: brianosman
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/52ede1d905728cdcaa98db1e4a33724f5a85c62d
Time: Mon Jun 20 15:25:02 2016
Lines 1180, 1189 of file SkCanvas.cpp which potentially caused crash are changed in this cl (frame #1, "SkCanvas::internalSaveLayer").
Minimum distance from crash line to modified line: 0. (file: SkCanvas.cpp, crashed on: 1180, modified: 1180).

@brianosman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: hcm@google.com

Comment 3 by hcm@chromium.org, Jun 1 2017

Labels: -Pri-2 Pri-3
recurring non-security int overflow, lowering priority

Comment 4 by hcm@chromium.org, Jun 1 2017

Cc: brianosman@chromium.org
Owner: ----
Project Member

Comment 5 by ClusterFuzz, Aug 29 2017

ClusterFuzz has detected this issue as fixed in range 497765:497771.

Detailed report: https://clusterfuzz.com/testcase?key=5355316626849792

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkIRect::width
  SkCanvas::internalSaveLayer
  SkCanvas::saveLayer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=400445:400830
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=497765:497771

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5355316626849792

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5355316626849792 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment