New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727091 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in blink::NormalPage::SweepAndCompact

Project Member Reported by ClusterFuzz, May 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5859284733919232

Fuzzer: inferno_twister
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7e8783b018f0
Crash State:
  blink::NormalPage::SweepAndCompact
  blink::NormalPageArena::SweepAndCompact
  blink::ThreadState::Compact
  
Sanitizer: thread (TSAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5859284733919232


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>MemoryAllocator
Labels: M-60 Test-Predator-Correct-CLs
Owner: sigbjo...@opera.com
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
Regression information is not available. The result is the blame information. 

Author: sigbjornf
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/2c7d13f7694fa208d996947731eacd152902ebdd
Time: Tue Dec 13 11:33:21 2016
The CL last changed line 201 of file HeapCompact.cpp, which is stack frame 0.

@sigbjornf -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by rtoy@chromium.org, Jun 8 2017

Cc: sigbjo...@opera.com ranjitkan@chromium.org aarya@google.com
 Issue 729275  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548a4efe0d1cf9aa4958b1b73d53a9f0b1126a89

commit 548a4efe0d1cf9aa4958b1b73d53a9f0b1126a89
Author: sigbjornf <sigbjornf@opera.com>
Date: Thu Jun 08 21:10:42 2017

Avoid unsafe heap access from audio thread.

The audio thread tries to touch main thread Blink GCed objects in a
select few places, which isn't safe as a GC might concurrently run.

Avoid such cross off-thread usage, rearrange the processing of
finished nodes from the audio thread to the main thread.

R=hongchan,rtoy,haraken
BUG= 727091 , 729275 

Review-Url: https://codereview.chromium.org/2913303002
Cr-Commit-Position: refs/heads/master@{#478084}

[modify] https://crrev.com/548a4efe0d1cf9aa4958b1b73d53a9f0b1126a89/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/548a4efe0d1cf9aa4958b1b73d53a9f0b1126a89/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/548a4efe0d1cf9aa4958b1b73d53a9f0b1126a89/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Jun 9 2017

ClusterFuzz has detected this issue as fixed in range 478007:478121.

Detailed report: https://clusterfuzz.com/testcase?key=5859284733919232

Fuzzer: inferno_twister
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7e8783b018f0
Crash State:
  blink::NormalPage::SweepAndCompact
  blink::NormalPageArena::SweepAndCompact
  blink::ThreadState::Compact
  
Sanitizer: thread (TSAN)

Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=478007:478121

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5859284733919232


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment