New issue
Advanced search Search tips

Issue 727020 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

bluetooth: macOS: Using Mac suffix when returning Mac instances

Project Member Reported by jlebel@chromium.org, May 27 2017

Issue description

Those methods:
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattService()
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptor()

should be renamed to:
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattServiceMac()
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptorMac()

To keep consistency with other methods from BluetoothLowEnergyServiceMac
and BluetoothLowEnergyCharacteristicMac.
 

Comment 1 by jlebel@chromium.org, May 27 2017

Summary: bluetooth: macOS: Using Mac suffix when returning Mac instances (was: bluetooth: macOS: Using Mac prefix when returning Mac instances)

Comment 2 by jlebel@chromium.org, May 28 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78a4bf70e96b31083ca6255ef9f9c3c81b5e5653

commit 78a4bf70e96b31083ca6255ef9f9c3c81b5e5653
Author: jlebel <jlebel@chromium.org>
Date: Tue May 30 00:09:58 2017

bluetooth: macOS: Adding Mac suffix

Adding Mac suffix to the following methods to keep consistency:
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattService()
BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptor()

BUG= 727020 

Review-Url: https://codereview.chromium.org/2912603002
Cr-Commit-Position: refs/heads/master@{#475397}

[modify] https://crrev.com/78a4bf70e96b31083ca6255ef9f9c3c81b5e5653/device/bluetooth/bluetooth_low_energy_device_mac.h
[modify] https://crrev.com/78a4bf70e96b31083ca6255ef9f9c3c81b5e5653/device/bluetooth/bluetooth_low_energy_device_mac.mm

Comment 4 by jlebel@chromium.org, May 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment