Issue metadata
Sign in to add a comment
|
Stackoverflow in v8::internal::Object::IsArray(v8::internal::Handle<v8::internal::Object>) using Proxy
Reported by
june901...@gmail.com,
May 27 2017
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36
Steps to reproduce the problem:
1. open a poc.html in chrome
What is the expected behavior?
maybe true
What went wrong?
crash occurs.
In v8, object.cc
842 Maybe<bool> Object::IsArray(Handle<Object> object) {
843 if (object->IsJSArray()) return Just(true);
844 if (object->IsJSProxy()) {
845 Handle<JSProxy> proxy = Handle<JSProxy>::cast(object);
846 Isolate* isolate = proxy->GetIsolate();
847 if (proxy->IsRevoked()) {
848 isolate->Throw(*isolate->factory()->NewTypeError(
849 MessageTemplate::kProxyRevoked,
850 isolate->factory()->NewStringFromAsciiChecked("IsArray")));
851 return Nothing<bool>();
852 }
853 return Object::IsArray(handle(proxy->target(), isolate)); // <<-- calls Object:IsArray infinitely
854 }
855 return Just(false);
856 }
Crashed report ID: daffc851-27a2-41aa-af2f-185b3ae7699c
How much crashed? Just one tab
Is it a problem with a plugin? N/A
Did this work before? N/A
Chrome version: 58.0.3029.110 Channel: stable
OS Version: 10.0
Flash Version:
,
Jun 6 2017
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/cdd58d08999c9adb5173c4728ca3754464da2b50 commit cdd58d08999c9adb5173c4728ca3754464da2b50 Author: Camillo Bruni <cbruni@chromium.org> Date: Wed Jun 07 14:47:31 2017 [proxies] Add stackoverflow check for JSProxy::isArray Bug: chromium:727000 Change-Id: I0fb6fecc9564aee97bcf7c0e9201c580572061be Reviewed-on: https://chromium-review.googlesource.com/525717 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#45767} [modify] https://crrev.com/cdd58d08999c9adb5173c4728ca3754464da2b50/src/objects-inl.h [modify] https://crrev.com/cdd58d08999c9adb5173c4728ca3754464da2b50/src/objects.cc [modify] https://crrev.com/cdd58d08999c9adb5173c4728ca3754464da2b50/src/objects.h [modify] https://crrev.com/cdd58d08999c9adb5173c4728ca3754464da2b50/src/prototype.h [modify] https://crrev.com/cdd58d08999c9adb5173c4728ca3754464da2b50/test/mjsunit/array-isarray.js
,
Jun 8 2017
,
Jun 9 2017
Verified this issue on Windows 10 with chrome #61.0.3124.10 and didn't observe any crash while loading provided html in comment #0.Hence adding TE-Verified labels Attaching the screen-cast for reference. Thank You... |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, May 31 2017Components: Blink>JavaScript
Labels: -Type-Bug -Pri-2 M-61 has-bisect-per-revision Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)