New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.vr_shell.WebVrTest#testPoseDataUnfocusedTab" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 27 2017

Issue description

"org.chromium.chrome.browser.vr_shell.WebVrTest#testPoseDataUnfocusedTab" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudnJfc2hlbGwuV2ViVnJUZXN0I3Rlc3RQb3NlRGF0YVVuZm9jdXNlZFRhYgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, May 29 2017

Detected 3 new flakes for test/step "org.chromium.chrome.browser.vr_shell.WebVrTest#testPoseDataUnfocusedTab". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudnJfc2hlbGwuV2ViVnJUZXN0I3Rlc3RQb3NlRGF0YVVuZm9jdXNlZFRhYgw. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by guidou@chromium.org, May 29 2017

Owner: isherman@chromium.org
Status: Assigned (was: Untriaged)
Disabling the flaky test.

isherman@: Can you take a look or help find a better owner?

Comment 3 by guidou@chromium.org, May 29 2017

Labels: -Sheriff-Chromium

Comment 4 by guidou@chromium.org, May 29 2017

Labels: Sheriff-Chromium

Comment 5 by guidou@chromium.org, May 29 2017

Cc: bshe@chromium.org
Owner: bsheedy@chromium.org
bsheedy@: Can you take a look or help find a better owner?

Comment 6 by guidou@chromium.org, May 29 2017

Labels: Tests-Disabled
Project Member

Comment 7 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab29c165afe3328b39948f1aaa19272d480c9a0b

commit ab29c165afe3328b39948f1aaa19272d480c9a0b
Author: guidou <guidou@chromium.org>
Date: Mon May 29 15:09:35 2017

Disable flaky WebVrTest#testPoseDataUnfocusedTab

BUG= 726986 
TBR=bsheedy@chromium.org

Review-Url: https://codereview.chromium.org/2910973002
Cr-Commit-Position: refs/heads/master@{#475352}

[modify] https://crrev.com/ab29c165afe3328b39948f1aaa19272d480c9a0b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java

Comment 8 by guidou@chromium.org, May 29 2017

Labels: -Pri-1 -Sheriff-Chromium Pri-2
I'm the best owner for this, taking a look now.
I am no longer able to reproduce this after 200 attempts. The flakiness seems to have started around the time the VR tests got moved to JUnit4, and several changes to cleanup and improve the test code went in shortly after the test was disabled that seem to have fixed the issue.

I'll go ahead and re-enable the test, but watch it for a few days to make sure the flakiness doesn't come back.
Test is still flaky after all, reverting now.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543b452a3bc62f2ee2dc997b540ef5a24c34fedf

commit 543b452a3bc62f2ee2dc997b540ef5a24c34fedf
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Fri Jun 02 00:31:20 2017

Revert "Re-enable WebVrTest#testPoseDataUnfocusedTab"

This reverts commit eb03fb7939f30e7fce920efde586aed6ff0a1ff3.

Reason for revert: Test is still flaky after all.

Original change's description:
> Re-enable WebVrTest#testPoseDataUnfocusedTab
> 
> Re-enables the previously flaky WebVrTest#testPoseDataUnfocusedTab.
> Flakiness appears to have been caused by the move to JUnit4 and fixed
> in one of the CLs that did additional cleanup and improvements after the move.
> 
> Bug:  726986 
> Change-Id: I6e54b87e21eaed91ac668125857c09e6df4b46e2
> Reviewed-on: https://chromium-review.googlesource.com/521842
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476409}

TBR=mthiesse@chromium.org,bsheedy@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  726986 

Change-Id: Iecf5abe7ab0f1d27dcb149ca53f480f758de7be3
Reviewed-on: https://chromium-review.googlesource.com/522182
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476498}
[modify] https://crrev.com/543b452a3bc62f2ee2dc997b540ef5a24c34fedf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aeb968c2aa350e449ff814a50304b640061e75d

commit 4aeb968c2aa350e449ff814a50304b640061e75d
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Jun 09 00:09:16 2017

Fix and re-enable WebVR test

Fixes and re-enables WebVrTest#testPoseDataUnfocusedTab. It looks like
it wasn't actually flaky, but instead running into  crbug.com/724261 
intermittently.

Was able to reproduce issue without the fix, but haven't been able to
with the fix after ~2000 test runs.

Bug:  726986 
Change-Id: I8680a53a83841e69416154e3ee65f8da24ced17d
Reviewed-on: https://chromium-review.googlesource.com/528416
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478129}
[modify] https://crrev.com/4aeb968c2aa350e449ff814a50304b640061e75d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[modify] https://crrev.com/4aeb968c2aa350e449ff814a50304b640061e75d/chrome/test/data/android/webvr_instrumentation/html/test_pose_data_unfocused_tab.html

Status: Fixed (was: Assigned)
I'll go ahead and close this since the test has been re-enabled and non-flaky for several days.
Components: Tests>Disabled
Labels: Test-Disabled
Labels: VR-Caught-By-Test
Labels: -VR-Caught-By-Test XR-Caught-By-Test

Sign in to add a comment