New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726977 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.VideoRotateToFullscreenTest#testPortraitToLandscapeAndBack" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 27 2017

Issue description

"org.chromium.content.browser.VideoRotateToFullscreenTest#testPortraitToLandscapeAndBack" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYgsSBUZsYWtlIldvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpZGVvUm90YXRlVG9GdWxsc2NyZWVuVGVzdCN0ZXN0UG9ydHJhaXRUb0xhbmRzY2FwZUFuZEJhY2sM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by guidou@chromium.org, May 29 2017

Owner: joh...@chromium.org
Status: Assigned (was: Untriaged)
johnme@: Can you take a look or help find a better owner?

Comment 2 by guidou@chromium.org, May 29 2017

Labels: Tests-Disabled

Comment 3 by guidou@chromium.org, May 29 2017

Labels: -Tests-Disabled

Comment 4 by guidou@chromium.org, May 29 2017

Labels: -Sheriff-Chromium Tests-Disabled
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f52fbbbd7fbbab148a29deae8d275e6f76b74557

commit f52fbbbd7fbbab148a29deae8d275e6f76b74557
Author: guidou <guidou@chromium.org>
Date: Mon May 29 16:06:56 2017

Disable flaky VideoRotateToFullscreenTest#testPortraitToLandscapeAndBack

BUG=726977
TBR=johnme@chromium.org

Review-Url: https://codereview.chromium.org/2912693003
Cr-Commit-Position: refs/heads/master@{#475358}

[modify] https://crrev.com/f52fbbbd7fbbab148a29deae8d275e6f76b74557/content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java

Cc: joh...@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da7ec98b04ecba7b3e997b9bb3e3d50a10dbde3

commit 6da7ec98b04ecba7b3e997b9bb3e3d50a10dbde3
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Dec 21 13:45:10 2017

Media Controls: workaround a bug in device orientation where the backend requires a v8::Context in the stack.

Also re-enables the rotate-to-fullscreen that were disabled without the
team being notified. It is fixing one source of flakyness. Another one
will require further investigation.

Bug:  794713 , 726977
Change-Id: Ib2f5443c1b312aca57db82e8682d76c01cf2ba21
Reviewed-on: https://chromium-review.googlesource.com/829733
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525683}
[modify] https://crrev.com/6da7ec98b04ecba7b3e997b9bb3e3d50a10dbde3/content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java
[modify] https://crrev.com/6da7ec98b04ecba7b3e997b9bb3e3d50a10dbde3/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
The test is still very flaky on android_n5x_swarming_rel. Re-disabling it.
jbrudorick@, would it be possible to paste a link to a test failure? It's going to be hard for me to find the failing bot otherwise :(
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12faebfe1cc4b2a8886aa3d8dbb542f738e716e6

commit 12faebfe1cc4b2a8886aa3d8dbb542f738e716e6
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Dec 21 18:59:47 2017

Re-disable VideoRotateToFullscreenTest.testPortraitToLandscapeAndBack.

TBR=mlamouri@chromium.org

Bug: 726977
Change-Id: Iaff166bc36ba3e27421d51968d671576e0e07a18
Reviewed-on: https://chromium-review.googlesource.com/840446
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525756}
[modify] https://crrev.com/12faebfe1cc4b2a8886aa3d8dbb542f738e716e6/content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java

Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Dec 22 2017

Labels: Sheriff-Chromium
Detected 15 new flakes for test/step "org.chromium.content.browser.VideoRotateToFullscreenTest#testPortraitToLandscapeAndBack". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYgsSBUZsYWtlIldvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpZGVvUm90YXRlVG9GdWxsc2NyZWVuVGVzdCN0ZXN0UG9ydHJhaXRUb0xhbmRzY2FwZUFuZEJhY2sM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 14 by mek@chromium.org, Dec 22 2017

Labels: -Sheriff-Chromium
Removing from sheriff queue, since the test is disabled and bug is assigned, so nothing to do for a sheriff at the moment.
Labels: Test-Disabled
Adding Test-Disabled label, the Tests>Disabled component is going away.
Labels: Hotlist-DisableReview
@mlamouri any updates for this disabled test?

Sign in to add a comment