New issue
Advanced search Search tips

Issue 726959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Unconditionally delete the unpack path in the UpdateClient.

Project Member Reported by sorin@chromium.org, May 27 2017

Issue description

Doing so, enforces that temporary files are not left behind after unpacking, even if installing of a CRX fails.
 

Comment 2 by sorin@chromium.org, May 31 2017

Labels: Merge-Request-60
Status: (was: Untriaged)

Comment 3 by sorin@chromium.org, May 31 2017

Labels: -Pri-3 Pri-2
Status: Started
Project Member

Comment 4 by sheriffbot@chromium.org, May 31 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993e502cb59a07df852caf1d6c940c998b71f04f

commit 993e502cb59a07df852caf1d6c940c998b71f04f
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed May 31 21:55:03 2017

Unconditionally delete the unpack path in the UpdateClient.

Bug:  726959 
Change-Id: I002aa30ee0d85d845dba915d9dbd6e5599218184
Reviewed-on: https://chromium-review.googlesource.com/517463
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475648}
Review-Url: https://codereview.chromium.org/2918653003 .
Cr-Commit-Position: refs/branch-heads/3112@{#65}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/993e502cb59a07df852caf1d6c940c998b71f04f/components/update_client/component.cc
[modify] https://crrev.com/993e502cb59a07df852caf1d6c940c998b71f04f/components/update_client/test_installer.cc
[modify] https://crrev.com/993e502cb59a07df852caf1d6c940c998b71f04f/components/update_client/test_installer.h
[modify] https://crrev.com/993e502cb59a07df852caf1d6c940c998b71f04f/components/update_client/update_client_unittest.cc

Comment 6 by sorin@chromium.org, Jun 1 2017

Status: Fixed (was: Started)

Sign in to add a comment