New issue
Advanced search Search tips

Issue 726957 link

Starred by 2 users
Status: Assigned
Owner:
rjkroege@chromium.org
Cc:
sunn...@chromium.org
ccameron@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 898680
issue 641132



Sign in to add a comment

Allow splitting quad list to be drawn into multiple GL surfaces.

Project Member Reported by jbau...@chromium.org, May 27 2017 
On Windows we won't be able to draw hardware encrypted video resources using the GL renderer, but will need to make DirectComposition layers out of them. This currently works fine in most cases, but we don't support that if the quad is in a non-root renderpass or is partially-opaque and has contents on top of it.

In those cases we'll need to render to two GLSurfaces, one under the quad and one on top of it, so they can be put in separate DirectComposition visuals so the z-order works out. In the case where those are inside a RenderPass, we'll need to split the parent RenderPass around that RPDQ and do the same thing recursively.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec

commit 196982d4d2cb3b3d2b3f0a6a432c2176e11110ec
Author: jbauman <jbauman@chromium.org>
Date: Mon Jun 12 22:36:51 2017

Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926763002
Cr-Commit-Position: refs/heads/master@{#478794}

[modify] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/gpu/ipc/service/BUILD.gn
[add] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/gpu/ipc/service/direct_composition_child_surface_win.cc
[add] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/gpu/ipc/service/direct_composition_child_surface_win.h
[modify] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/ui/gl/scoped_make_current.cc
[modify] https://crrev.com/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec/ui/gl/scoped_make_current.h

Comment 2 by jbau...@chromium.org, Aug 8 2017

Blocking: 641132

Comment 3 by jbau...@chromium.org, Aug 10 2017

Owner: ----
Status: Available (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by enne@chromium.org, Aug 17

Owner: rjkroege@chromium.org
Status: Assigned (was: Untriaged)
Assigning to rjkroege to triage this feature request as a part of overlay refactoring.

Comment 6 by rjkroege@chromium.org, Aug 20 

I'll figure out who should own.

Comment 7 by rjkroege@chromium.org, Oct 24

Blocking: 898680
►

Sign in to add a comment